feat(vitest-pool-workers): add support for vitest 3.2.x#9439
Merged
edmundhung merged 3 commits intomainfrom Jun 11, 2025
Merged
feat(vitest-pool-workers): add support for vitest 3.2.x#9439edmundhung merged 3 commits intomainfrom
edmundhung merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 8dc062e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-wrangler-9439Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-workers-bindings-extension-9439 -O ./cloudflare-workers-bindings-extension.0.0.0-vfc78a753f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfc78a753f.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-create-cloudflare-9439 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-kv-asset-handler-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-miniflare-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-pages-shared-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-unenv-preset-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-vite-plugin-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-vitest-pool-workers-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-workers-editor-shared-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-workers-shared-9439
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15394930719/npm-package-cloudflare-workflows-shared-9439Note that these links will no longer work once the GitHub Actions artifact expires. |
edmundhung
commented
Jun 9, 2025
Comment on lines
-359
to
-365
| async onCancel(reason: CancelReason) { | ||
| if (DEBUG) { | ||
| __console.log(`onCancel: ${reason}`); | ||
| await scheduler.wait(100); | ||
| } | ||
| return super.onCancel(reason); | ||
| } |
Member
Author
There was a problem hiding this comment.
The onCancel method is renamed to cancel on Vitest 3.2 (https://github.com/vitest-dev/vitest/pull/7878/files#r2058686709)
We can rename it and check whether the method exists, but it seems to be redundant for users as we were adding it just for debug purpose and will require us modify the debug flag manually instead of a user facing config.
d7130ad to
14f7956
Compare
petebacondarwin
approved these changes
Jun 9, 2025
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Assuming CI is happy
14f7956 to
52012f9
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
3 tasks
52012f9 to
23871ec
Compare
23871ec to
8dc062e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9521