Turn on --x-registry for Pages by default#7381
Merged
Conversation
🦋 Changeset detectedLatest commit: b5673b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emily-shen
approved these changes
Nov 28, 2024
Contributor
emily-shen
left a comment
There was a problem hiding this comment.
yay thanks for fixing this 🎉
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-wrangler-7381You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7381/npm-package-wrangler-7381Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-wrangler-7381 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-create-cloudflare-7381 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-cloudflare-kv-asset-handler-7381npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-miniflare-7381npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-cloudflare-pages-shared-7381npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-cloudflare-vitest-pool-workers-7381npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-cloudflare-workers-editor-shared-7381npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-cloudflare-workers-shared-7381npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12071540049/npm-package-cloudflare-workflows-shared-7381Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7322
When flipping the
--x-registrydefault, we forgot to turn it on for Pages, resulting in Pages and Workers not being able to connect over service bindings unless--x-registry=falsewas specified on the Worker invocation. Our tests didn't catch this because they always specified the--x-registryflag (for both the true and false case), and so the defaults weren't being tested. This PR:truefor Pages