Skip to content

Revert "Add serve_directly option to assets configuration (#7316)"#7351

Merged
lrapoport-cf merged 1 commit intomainfrom
revert-7316
Nov 26, 2024
Merged

Revert "Add serve_directly option to assets configuration (#7316)"#7351
lrapoport-cf merged 1 commit intomainfrom
revert-7316

Conversation

@emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Nov 26, 2024

This reverts commit 3cdf0e8.

Fixes #[insert GH or internal issue link(s)].

Describe your change...

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@emily-shen emily-shen added skip-pr-description-validation Skip validation of the required PR description format no-changeset-required labels Nov 26, 2024
@emily-shen emily-shen requested review from a team as code owners November 26, 2024 18:03
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 986b09c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-wrangler-7351

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7351/npm-package-wrangler-7351

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-wrangler-7351 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-create-cloudflare-7351 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-cloudflare-kv-asset-handler-7351
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-miniflare-7351
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-cloudflare-pages-shared-7351
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-cloudflare-vitest-pool-workers-7351
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-cloudflare-workers-editor-shared-7351
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-cloudflare-workers-shared-7351
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12036419312/npm-package-cloudflare-workflows-shared-7351

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.90.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@lrapoport-cf lrapoport-cf merged commit cc93b2c into main Nov 26, 2024
@lrapoport-cf lrapoport-cf deleted the revert-7316 branch November 26, 2024 18:56
@emily-shen emily-shen mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillTaylorDev WillTaylorDev WillTaylorDev approved these changes

@lrapoport-cf lrapoport-cf lrapoport-cf approved these changes

Assignees

No one assigned

Labels

no-changeset-required skip-pr-description-validation Skip validation of the required PR description format

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emily-shen @WillTaylorDev @lrapoport-cf