Skip to content

feat(wrangler): setup x-provision flag#7348

Merged
edmundhung merged 6 commits intomainfrom
edmundhung/DEVX-1422
Nov 27, 2024
Merged

feat(wrangler): setup x-provision flag#7348
edmundhung merged 6 commits intomainfrom
edmundhung/DEVX-1422

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Nov 26, 2024 •
edited
Loading

Fixes DEVX-1422.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no feature implemented on the experimental flag yet
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no impact to existing features
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: unreleased experimental feature

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7d4ca23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-wrangler-7348

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7348/npm-package-wrangler-7348

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-wrangler-7348 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-create-cloudflare-7348 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-kv-asset-handler-7348
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-miniflare-7348
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-pages-shared-7348
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-vitest-pool-workers-7348
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-workers-editor-shared-7348
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-workers-shared-7348
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-workflows-shared-7348

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.91.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung marked this pull request as ready for review November 27, 2024 10:49
@edmundhung edmundhung requested a review from a team as a code owner November 27, 2024 10:49
penalosa
penalosa approved these changes Nov 27, 2024
View reviewed changes
packages/wrangler/src/experimental-flags.ts Outdated
Comment on lines +5 to +6
FILE_BASED_REGISTRY?: boolean;
RESOURCES_PROVISION?: boolean;
Copy link
Contributor

@penalosa penalosa Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason to make these optional? Since it's an internal API I feel like it'd be better to keep these required?

Copy link
Member Author

@edmundhung edmundhung Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly to avoid the need to update the feature flag on every place we run an async context. If you prefer making it explicit, I can change that.

Copy link
Member Author

@edmundhung edmundhung Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ab67e0d

packages/wrangler/src/index.ts Outdated
return true;
})
.option("experimental-provision", {
describe: `Automatic resources provision`,
Copy link
Contributor

@penalosa penalosa Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe: `Automatic resources provision`,
describe: `Experimental: Enable automatic resource provisioning`,

Copy link
Member Author

@edmundhung edmundhung Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4e33617

@edmundhung edmundhung merged commit 4cd8b46 into main Nov 27, 2024
@edmundhung edmundhung deleted the edmundhung/DEVX-1422 branch November 27, 2024 15:25
@workers-devprod workers-devprod mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penalosa penalosa penalosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edmundhung @penalosa