Skip to content

Print copyable wrangler.toml text when creating a hyperdrive config#7326

Merged
penalosa merged 3 commits intocloudflare:mainfrom
mtlemilio:print-wrangler-binding-when-creating-hyperdrive
Nov 27, 2024
Merged

Print copyable wrangler.toml text when creating a hyperdrive config#7326
penalosa merged 3 commits intocloudflare:mainfrom
mtlemilio:print-wrangler-binding-when-creating-hyperdrive

Conversation

@mtlemilio
Copy link
Contributor

@mtlemilio mtlemilio commented Nov 22, 2024

Fixes #[SQC-348].

This change gives wrangler users a quality of life improvement when creating a Hyperdrive config, giving them a copyable snippet to paste in their wrangler.toml file to bind their new Hyperdrive Config to their Worker.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Does not change logic around creating or updating Hyperdrive configs, only printing the results.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Does not change the API surface for the Hyperdrive command.

@mtlemilio mtlemilio requested a review from a team as a code owner November 22, 2024 20:48
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 622efac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-wrangler-7326

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7326/npm-package-wrangler-7326

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-wrangler-7326 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-create-cloudflare-7326 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-cloudflare-kv-asset-handler-7326
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-miniflare-7326
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-cloudflare-pages-shared-7326
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-cloudflare-vitest-pool-workers-7326
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-cloudflare-workers-editor-shared-7326
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-cloudflare-workers-shared-7326
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12055535658/npm-package-cloudflare-workflows-shared-7326

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.91.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should support both TOML & JSON

@mtlemilio mtlemilio force-pushed the print-wrangler-binding-when-creating-hyperdrive branch 3 times, most recently from 2b0cad9 to 7bb6da8 Compare November 27, 2024 17:35
@mtlemilio mtlemilio force-pushed the print-wrangler-binding-when-creating-hyperdrive branch from 7bb6da8 to 622efac Compare November 27, 2024 17:36
@sejoker
Copy link

sejoker commented Nov 27, 2024

This should support both TOML & JSON

this is now addressed.

@penalosa penalosa merged commit 24c752e into cloudflare:main Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants