Skip to content

run e2e tests on #7130#7283

Closed
emily-shen wants to merge 9 commits intomainfrom
e2e/7130
Closed

run e2e tests on #7130#7283
emily-shen wants to merge 9 commits intomainfrom
e2e/7130

Conversation

@emily-shen
Copy link
Contributor

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

In an npm workspace environment, wrangler will now be able to
successfully resolve package exports.

Previously, wrangler would only be able to resolve modules in a relative
`node_modules` directory and not workspace root `node_modules`
directory.
@emily-shen emily-shen requested a review from a team as a code owner November 18, 2024 15:01
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: c4b6c48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen added the e2e Run wrangler + vite-plugin e2e tests on a PR label Nov 18, 2024
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-wrangler-7283

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7283/npm-package-wrangler-7283

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-wrangler-7283 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-create-cloudflare-7283 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-cloudflare-kv-asset-handler-7283
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-miniflare-7283
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-cloudflare-pages-shared-7283
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-cloudflare-vitest-pool-workers-7283
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-cloudflare-workers-editor-shared-7283
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-cloudflare-workers-shared-7283
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11895139196/npm-package-cloudflare-workflows-shared-7283

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.87.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@lrapoport-cf
Copy link
Contributor

for posterity, confirmed with @emily-shen that this passed e2e tests on #7130 before it was then closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants