Skip to content

Make debug log for .env not found less scary#7272

Merged
penalosa merged 5 commits intomainfrom
penalosa/env-file-debug
Nov 28, 2024
Merged

Make debug log for .env not found less scary#7272
penalosa merged 5 commits intomainfrom
penalosa/env-file-debug

Conversation

@penalosa
Copy link
Contributor

Fixes #7042


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by unit tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: debug log change

@penalosa penalosa requested a review from a team as a code owner November 15, 2024 23:34
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 3f5e3b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-wrangler-7272

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7272/npm-package-wrangler-7272

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-wrangler-7272 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-create-cloudflare-7272 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-cloudflare-kv-asset-handler-7272
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-miniflare-7272
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-cloudflare-pages-shared-7272
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-cloudflare-vitest-pool-workers-7272
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-cloudflare-workers-editor-shared-7272
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-cloudflare-workers-shared-7272
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12068895332/npm-package-cloudflare-workflows-shared-7272

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.91.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

} catch (e) {
logger.debug(`Failed to load .env file "${path}":`, e);
if ((e as { code: string }).code === "ENOENT") {
logger.debug(`.env file not found at "${path}"`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely less scary but it still could be mistaken for an error - can we add a short message to say this is fine to ignore if you're not trying to use .dev.vars, .env etc.?

@penalosa penalosa force-pushed the penalosa/env-file-debug branch from f737b3c to 6213ba4 Compare November 22, 2024 17:50
@penalosa penalosa force-pushed the penalosa/env-file-debug branch from b3fc4d8 to 3f5e3b4 Compare November 28, 2024 12:28
@penalosa penalosa merged commit a3f56d1 into main Nov 28, 2024
@penalosa penalosa deleted the penalosa/env-file-debug branch November 28, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: .env file missing error when none exists and WRANGLER_LOG="debug"

5 participants