feat: support analytics engine in local/remote dev#6666
Merged
threepointone merged 1 commit intomainfrom Sep 10, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 7a14484 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-wrangler-6666You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6666/npm-package-wrangler-6666Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-wrangler-6666 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-create-cloudflare-6666 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-kv-asset-handler-6666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-miniflare-6666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-pages-shared-6666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-vitest-pool-workers-6666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-workers-editor-shared-6666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10795874947/npm-package-cloudflare-workers-shared-6666Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
threepointone
commented
Sep 10, 2024
| ) => { | ||
| // we're going to directly modify env so it maintains referential equality | ||
| for (const binding of bindings) { | ||
| env[binding] ??= bindingsEnv[binding]; |
Contributor
Author
There was a problem hiding this comment.
This makes it so the binding doesn't get overridden if it's previously set. Now, AE actually does work in remote mode, which means it'll track events. There's an argument to be made here that we should mock it even then.
penalosa
reviewed
Sep 10, 2024
packages/wrangler/templates/middleware/middleware-mock-analytics-engine.ts
Outdated
Show resolved
Hide resolved
This adds "support" for analytics engine datasets for `wrangler dev`. Specifically, it simply mocks the AE bindings so that they exist while developing (and don't throw when accessed). This does NOT add support in Pages, though we very well could do so in a similar way in a followup.
015b14b to
7a14484
Compare
penalosa
approved these changes
Sep 10, 2024
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds "support" for analytics engine datasets for
wrangler dev. Specifically, it simply mocks the AE bindings so that they exist while developing (and don't throw when accessed).This does NOT add support in Pages, though we very well could do so in a similar way in a followup.
What this PR solves / how to test
Fixes #5532
Fixes #4383 (maybe?)
Author has addressed the following