Skip to content

feat: add router worker to workers-shared#6537

Merged
emily-shen merged 3 commits intomainfrom
emily/router-worker
Aug 22, 2024
Merged

feat: add router worker to workers-shared#6537
emily-shen merged 3 commits intomainfrom
emily/router-worker

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Aug 20, 2024 •
edited by penalosa
Loading

What this PR solves / how to test

WC-2556
Adds in basic router worker, but does not wire it up to anything (e.g. miniflare)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: just scaffolding
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: new Worker
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: workers-shared is not documented

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4950487

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/workers-shared Minor
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 20, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-wrangler-6537

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6537/npm-package-wrangler-6537

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-wrangler-6537 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-create-cloudflare-6537 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-cloudflare-kv-asset-handler-6537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-miniflare-6537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-cloudflare-pages-shared-6537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-cloudflare-vitest-pool-workers-6537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-cloudflare-workers-editor-shared-6537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10505419358/npm-package-cloudflare-workers-shared-6537

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.72.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen force-pushed the emily/router-worker branch from 0cc09b6 to 93778ec Compare August 20, 2024 16:52
@emily-shen emily-shen marked this pull request as ready for review August 20, 2024 16:52
@emily-shen emily-shen requested a review from a team as a code owner August 20, 2024 16:52
CarmenPopoviciu
CarmenPopoviciu reviewed Aug 20, 2024
View reviewed changes
CarmenPopoviciu
CarmenPopoviciu reviewed Aug 20, 2024
View reviewed changes
CarmenPopoviciu
CarmenPopoviciu reviewed Aug 20, 2024
View reviewed changes
CarmenPopoviciu
CarmenPopoviciu reviewed Aug 20, 2024
View reviewed changes
@CarmenPopoviciu
Copy link
Copy Markdown
Contributor

CarmenPopoviciu commented Aug 22, 2024

@emily-shen thank you for working on this ♥️ . This will need a changeset and a minor bump to workers-shared. Can you please add that 🙏 ?

@emily-shen emily-shen merged commit f5bde66 into main Aug 22, 2024
@emily-shen emily-shen deleted the emily/router-worker branch August 22, 2024 09:27
@workers-devprod workers-devprod mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emily-shen @CarmenPopoviciu