Conversation
🦋 Changeset detectedLatest commit: bb5f21e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-wrangler-6532You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6532/npm-package-wrangler-6532Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-wrangler-6532 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-create-cloudflare-6532 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-cloudflare-kv-asset-handler-6532npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-miniflare-6532npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-cloudflare-pages-shared-6532npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-cloudflare-vitest-pool-workers-6532npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-cloudflare-workers-editor-shared-6532npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10470005449/npm-package-cloudflare-workers-shared-6532Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
andyjessop
left a comment
There was a problem hiding this comment.
Would it be possible to get a screenshot here, to get more context as to what is up for review?
| alignItems: "center", | ||
| width: "fit-content", | ||
| fontSize: theme.fontSizes[1], | ||
| color: `${theme.colors.indigo[isDarkMode() ? 9 : 2]} !important`, |
There was a problem hiding this comment.
It would be negligent of me not to ask why !important is needed here 😁
We could perhaps add a comment to explain.
There was a problem hiding this comment.
Honestly I'm not super sure—the intention here is to match the dashboard styles.
| color: `${theme.colors.indigo[isDarkMode() ? 9 : 2]} !important`, | ||
| backgroundColor: theme.colors.indigo[isDarkMode() ? 4 : 9], | ||
| borderRadius: "100vw", | ||
| px: 2, |
There was a problem hiding this comment.
What unit is 2? Is it rems?
There was a problem hiding this comment.
No, it's a unit in our design system, which ends up rendered as 8px
There was a problem hiding this comment.
Oh I see, it's like a "level". Fair enough, thanks for clarifying!
| "&:hover svg": { | ||
| color: theme.colors.indigo[isDarkMode() ? 9 : 2], | ||
| }, | ||
| }), |
There was a problem hiding this comment.
I feel like these styles should be shared somehow? Is this a button that looks similar to other buttons on the site, or are these styles specific to the docs link?
There was a problem hiding this comment.
The styling of this button is pretty unique to the docs link—it doesn't really look like anything else on the site
What this PR solves / how to test
Fixes https://jira.cfdata.org/browse/DEVX-1311
Adds a tab to the workers playground which calls out the C3 flow for creating a worker
Author has addressed the following