Skip to content

Fixed versions upload printing duplicate bindings#6530

Merged
CarmenPopoviciu merged 1 commit intomainfrom
walshy/WC-2563
Aug 20, 2024
Merged

Fixed versions upload printing duplicate bindings#6530
CarmenPopoviciu merged 1 commit intomainfrom
walshy/WC-2563

Conversation

@WalshyDev
Copy link
Copy Markdown
Member

What this PR solves / how to test

Fixes WC-2563

Bug:
image

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no e2e covering versions up,
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: just a bug fix

@WalshyDev WalshyDev requested a review from a team as a code owner August 19, 2024 22:09
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 25794cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WalshyDev WalshyDev added the e2e Run wrangler + vite-plugin e2e tests on a PR label Aug 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-wrangler-6530

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6530/npm-package-wrangler-6530

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-wrangler-6530 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-create-cloudflare-6530 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-cloudflare-kv-asset-handler-6530
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-miniflare-6530
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-cloudflare-pages-shared-6530
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-cloudflare-vitest-pool-workers-6530
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-cloudflare-workers-editor-shared-6530
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10462039000/npm-package-cloudflare-workers-shared-6530

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.72.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev force-pushed the walshy/WC-2563 branch 3 times, most recently from 84e5d59 to f1df159 Compare August 19, 2024 22:37
@CarmenPopoviciu CarmenPopoviciu merged commit d0ecc6a into main Aug 20, 2024
@CarmenPopoviciu CarmenPopoviciu deleted the walshy/WC-2563 branch August 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants