Skip to content

Prefix headers sent by the playground with cf-ew-raw-#6528

Merged
penalosa merged 2 commits intomainfrom
penalosa/playground-reserved-headers
Aug 20, 2024
Merged

Prefix headers sent by the playground with cf-ew-raw-#6528
penalosa merged 2 commits intomainfrom
penalosa/playground-reserved-headers

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Aug 19, 2024 •
edited
Loading

What this PR solves / how to test

Followup to #6458, part of https://jira.cfdata.org/browse/DEVX-1312. See https://github.com/cloudflare/wrangler2/blob/penalosa/shared-editor/packages/workers-playground/README.md for instructions on running the Playground locally to test this—the Cookie header is a good one to test with.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: Playground UI is manually tested
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: e2e doesn't apply to the playground
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal implementation detail

@penalosa penalosa requested a review from a team as a code owner August 19, 2024 20:02
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f9abeb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
workers-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-wrangler-6528

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6528/npm-package-wrangler-6528

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-wrangler-6528 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-create-cloudflare-6528 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-cloudflare-kv-asset-handler-6528
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-miniflare-6528
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-cloudflare-pages-shared-6528
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-cloudflare-vitest-pool-workers-6528
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-cloudflare-workers-editor-shared-6528
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10460124561/npm-package-cloudflare-workers-shared-6528

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.72.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

petebacondarwin
petebacondarwin approved these changes Aug 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame we can't have proper tests for this stuff.

@penalosa penalosa merged commit c3441c5 into main Aug 20, 2024
@penalosa penalosa deleted the penalosa/playground-reserved-headers branch August 20, 2024 07:42
@workers-devprod workers-devprod mentioned this pull request Aug 19, 2024
Merged
@lrapoport-cf lrapoport-cf mentioned this pull request Aug 20, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@penalosa @petebacondarwin