VS-197: Fix Vectorize List MetadataIndex Http Method#6502
VS-197: Fix Vectorize List MetadataIndex Http Method#6502CarmenPopoviciu merged 2 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 1e5df29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e352b32 to
1837932
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-wrangler-6502You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6502/npm-package-wrangler-6502Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-wrangler-6502 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-create-cloudflare-6502 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-cloudflare-kv-asset-handler-6502npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-miniflare-6502npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-cloudflare-pages-shared-6502npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-cloudflare-vitest-pool-workers-6502npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-cloudflare-workers-editor-shared-6502npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10421446175/npm-package-cloudflare-workers-shared-6502Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| demandOption: true, | ||
| describe: | ||
| "Vector to query the Vectorize Index. Example: `--vector 1 2 3 0.5 1.25 6`", | ||
| "Vector to query the Vectorize Index. Example: `--vector 1 2 3 0.5 1.25 6`. To read from a json file that contains data in the format [1, 2, 3], you could use a command like `--vector $(jq -r '.[]' data.json | xargs)`", |
There was a problem hiding this comment.
nit: I'm a little worried about the verbosity here. The scope of the added copy feels more like docs scope rather than CLI help scope. Looking at the wrangler vectorize query help output, it's looking like 👇 , which feels a bit difficult to read IMHO. Was this considered, and are we sure this is what we want here?
There was a problem hiding this comment.
Well the idea was to provide some additional guidance to the customers and make it easier for them to use the query operation. But it is unrelated to the fix in this PR, and I can remove it to unblock the fix if the verbosity is a cause for concern.
There was a problem hiding this comment.
I have an idea how we can fix this! Stay tuned...
|
Congratulations @garvit-gupta, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/clzwwscsk37410djuyg2jtgi0 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What this PR solves / how to test
Fixes VS-197. Fix Vectorize List MetadataIndex Http Method. Currently POST, changed it to GET.
Author has addressed the following