Support setting custom HTTPS certification paths from environment variables#6479
Merged
petebacondarwin merged 3 commits intomainfrom Aug 14, 2024
Merged
Support setting custom HTTPS certification paths from environment variables#6479petebacondarwin merged 3 commits intomainfrom
petebacondarwin merged 3 commits intomainfrom
Conversation
…nment variables As well as providing paths to custom HTTPS certificate files, it is now possible to use WRANGLER_HTTPS_KEY_PATH and WRANGLER_HTTPS_CERT_PATH environment variables. Specifying the file paths at the command line overrides specifying in environment variables. Fixes #5997
…n Wrangler tests This helper from Vitest will automatically revert to the original process.env values after each test.
🦋 Changeset detectedLatest commit: 4ef97ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-wrangler-6479You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6479/npm-package-wrangler-6479Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-wrangler-6479 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-create-cloudflare-6479 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-kv-asset-handler-6479npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-miniflare-6479npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-pages-shared-6479npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-vitest-pool-workers-6479npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-workers-editor-shared-6479npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10368361203/npm-package-cloudflare-workers-shared-6479Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
CarmenPopoviciu
approved these changes
Aug 14, 2024
Contributor
CarmenPopoviciu
left a comment
There was a problem hiding this comment.
really nice one Pete! Thank you for working on this <3
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
(Note that there are two auxiliary commits in this PR, which can be reviewed independently.)
Fixes #5997
Author has addressed the following