fix: add support for node-like module resolution#4748
fix: add support for node-like module resolution#4748petebacondarwin merged 5 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 36a833b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7533584307/npm-package-wrangler-4748You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7533584307/npm-package-wrangler-4748Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7533584307/npm-package-wrangler-4748 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7533584307/npm-package-miniflare-4748npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7533584307/npm-package-cloudflare-pages-shared-4748npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7533584307/npm-package-create-cloudflare-4748 --no-auto-updateNote that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4748 +/- ##
==========================================
+ Coverage 75.63% 75.74% +0.10%
==========================================
Files 243 243
Lines 13210 13226 +16
Branches 3393 3396 +3
==========================================
+ Hits 9992 10018 +26
+ Misses 3218 3208 -10
|
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM - thanks for the fix.
Would you mind adjusting the changeset?
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
|
Thanks @petebacondarwin, updated as suggested. |
Fixes #4726
What this PR solves / how to test:
Similar to #4135, this extends the module collection plugin to support standard node-like resolution of file paths.
This allows you to do things like:
even when the package doesn't explicitly export that file in its
exportsmap.This uses
resolve, a package that was already in the dependency tree, and used throughout the JS ecosystem everywhere such as invite,jest,eslint-plugin-import, etc.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.