Skip to content

Fix CSP:script-src in 0015-Basic-support-for-Safari.patch (#4737)#4738

Merged
penalosa merged 2 commits intocloudflare:mainfrom
neilsh:patch-1
Aug 22, 2024
Merged

Fix CSP:script-src in 0015-Basic-support-for-Safari.patch (#4737)#4738
penalosa merged 2 commits intocloudflare:mainfrom
neilsh:patch-1

Conversation

@neilsh
Copy link
Copy Markdown
Contributor

@neilsh neilsh commented Jan 11, 2024 •
edited by penalosa
Loading

Potential fix for #4737. Note that I haven't tested this myself, as I don't have an environment set up for wrangler-devtools -- feel free to modify this from draft->ready once tested.

Fixes #4737

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: this package is manually tested
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: bugfix

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c2d3458

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/wrangler-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa added the preview:chrome-devtools-patches Trigger a devtools preview deploy label Feb 22, 2024
@penalosa penalosa marked this pull request as ready for review February 22, 2024 16:06
@penalosa penalosa requested a review from a team as a code owner February 22, 2024 16:06
@penalosa penalosa self-assigned this Feb 22, 2024
petebacondarwin
petebacondarwin approved these changes Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't have the ability to test this locally.
Should we be able to from the Pages preview?

@penalosa
Copy link
Copy Markdown
Contributor

penalosa commented Feb 22, 2024

Also don't have the ability to test this locally. Should we be able to from the Pages preview?

Yes we should, but for some reason that's not currently working. I'm investigating

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-wrangler-4738

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4738/npm-package-wrangler-4738

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-wrangler-4738 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-create-cloudflare-4738 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-kv-asset-handler-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-miniflare-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-pages-shared-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-vitest-pool-workers-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-workers-editor-shared-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-workers-shared-4738

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.72.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa
Copy link
Copy Markdown
Contributor

penalosa commented Aug 22, 2024

Manually tested from a build in #6556

@penalosa penalosa merged commit a9f36ef into cloudflare:main Aug 22, 2024
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Aug 22, 2024
@holopin-bot
Copy link
Copy Markdown

holopin-bot bot commented Aug 22, 2024

Congratulations @neilsh, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm05981x694580cllj4qbvgw3

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@penalosa penalosa penalosa approved these changes

Assignees

@penalosa penalosa

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small preview:chrome-devtools-patches Trigger a devtools preview deploy

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 BUG: typo in wrangler-devtools Content-Security-Policy

4 participants

@neilsh @penalosa @petebacondarwin @workers-devprod