[wrangler] Backport recent inspector proxy server changes to V2#4587
Merged
mrbbot merged 2 commits intov2-maintenancefrom Dec 12, 2023
Merged
[wrangler] Backport recent inspector proxy server changes to V2#4587mrbbot merged 2 commits intov2-maintenancefrom
mrbbot merged 2 commits intov2-maintenancefrom
Conversation
🦋 Changeset detectedLatest commit: ab6c4cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
penalosa
approved these changes
Dec 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v2-maintenance #4587 +/- ##
=================================================
Coverage ? 74.52%
=================================================
Files ? 179
Lines ? 10940
Branches ? 2911
=================================================
Hits ? 8153
Misses ? 2787
Partials ? 0 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
This PR backports some changes we recently made to the Wrangler 3's inspector proxy to Wrangler 2. Specifically, the inspector server now listens on local interfaces by default, and validates incoming
Host/Originheaders.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.