Skip to content

wrangler: Implement hyperdrive command#3999

Merged
RamIdeas merged 12 commits intocloudflare:mainfrom
mtlemilio:oilylime/hyperdrive-support
Sep 26, 2023
Merged

wrangler: Implement hyperdrive command#3999
RamIdeas merged 12 commits intocloudflare:mainfrom
mtlemilio:oilylime/hyperdrive-support

Conversation

@mtlemilio
Copy link
Contributor

@mtlemilio mtlemilio commented Sep 20, 2023 •
edited
Loading

What this PR solves / how to test:
Adds support for hyperdrive.

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@mtlemilio mtlemilio requested a review from a team as a code owner September 20, 2023 22:56
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 2f209a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mtlemilio mtlemilio mentioned this pull request Sep 20, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6315042400/npm-package-wrangler-3999

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6315042400/npm-package-wrangler-3999

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6315042400/npm-package-wrangler-3999 dev path/to/script.js
Additional artifacts: 
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6315042400/npm-package-cloudflare-pages-shared-3999

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.9.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230922.0 3.20230922.0
workerd 1.20230922.0 1.20230922.0
workerd --version 1.20230922.0 2023-09-22

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@mtlemilio mtlemilio force-pushed the oilylime/hyperdrive-support branch from 71f6231 to c6be27f Compare September 20, 2023 23:04
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #3999 (2f209a2) into main (d538973) will increase coverage by 0.03%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3999      +/-   ##
==========================================
+ Coverage   74.96%   74.99%   +0.03%     
==========================================
  Files         207      215       +8     
  Lines       11832    11987     +155     
  Branches     3081     3111      +30     
==========================================
+ Hits         8870     8990     +120     
- Misses       2962     2997      +35
Files Coverage Δ
...ler/src/api/pages/create-worker-bundle-contents.ts 100.00% <ø> (ø)
packages/wrangler/src/config/index.ts 89.82% <100.00%> (+0.24%) ⬆️
packages/wrangler/src/deploy/deploy.ts 87.33% <ø> (ø)
...src/deployment-bundle/create-worker-upload-form.ts 88.80% <100.00%> (+0.18%) ⬆️
packages/wrangler/src/dev.tsx 83.19% <ø> (ø)
packages/wrangler/src/hyperdrive/common.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/delete.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/get.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/index.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/list.ts 100.00% <100.00%> (ø)
... and 6 more

... and 3 files with indirect coverage changes

elithrar
elithrar reviewed Sep 21, 2023
View reviewed changes
jspspike
jspspike approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@jspspike jspspike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and commands look good. Didn't scrutinize the hyperdrive specific logic too closely but the tests make sense and wrangler changes look good

@mtlemilio mtlemilio requested a review from a team as a code owner September 22, 2023 15:58
@mtlemilio mtlemilio force-pushed the oilylime/hyperdrive-support branch 4 times, most recently from c6965b3 to 29fcf2b Compare September 22, 2023 20:01
JacobMGEvans
JacobMGEvans approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the testing not covering the new bindings validation, in config validation.ts it looks good to me.

@RamIdeas
Copy link
Contributor

RamIdeas commented Sep 26, 2023 •
edited
Loading

Needs a rebase but LGTM

EDIT: I'm doing the rebase now

@RamIdeas RamIdeas force-pushed the oilylime/hyperdrive-support branch from 56268bd to c8fc636 Compare September 26, 2023 14:18
@RamIdeas RamIdeas force-pushed the oilylime/hyperdrive-support branch from c8fc636 to 9402fbb Compare September 26, 2023 15:30
@RamIdeas RamIdeas merged commit ee6f345 into cloudflare:main Sep 26, 2023
@workers-devprod workers-devprod mentioned this pull request Sep 26, 2023
Merged
@mtlemilio mtlemilio changed the title wrangler: Improvements wrangler: Implement hyperdrive command Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elithrar elithrar elithrar left review comments

+3 more reviewers

@jspspike jspspike jspspike approved these changes

@RamIdeas RamIdeas RamIdeas approved these changes

@JacobMGEvans JacobMGEvans JacobMGEvans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtlemilio @RamIdeas @elithrar @jspspike @JacobMGEvans