Skip to content

Upgrade rimraf from v3 to v5 #3511

Merged
JacobMGEvans merged 4 commits intomainfrom
jacobmgevans/upgrade-rimraf
Jun 30, 2023
Merged

Upgrade rimraf from v3 to v5 #3511
JacobMGEvans merged 4 commits intomainfrom
jacobmgevans/upgrade-rimraf

Conversation

@JacobMGEvans
Copy link
Copy Markdown
Contributor

@JacobMGEvans JacobMGEvans commented Jun 22, 2023

The upgrade provides a few performance benefits and reliability in different OS systems. see: https://github.com/isaacs/rimraf\#major-changes

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

The upgrade provides a few performance benefits and reliability in different OS systems. see: https://github.com/isaacs/rimraf\#major-changes
@JacobMGEvans JacobMGEvans added the maintenance Maintenance task label Jun 22, 2023
@JacobMGEvans JacobMGEvans requested review from a team as code owners June 22, 2023 21:03
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: 3943b7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wranglerjs-compat-webpack-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 22, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5357577961/npm-package-wrangler-3511

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3511/npm-package-wrangler-3511

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5357577961/npm-package-wrangler-3511 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5357577961/npm-package-cloudflare-pages-shared-3511

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 22, 2023

Codecov Report

Merging #3511 (cbd19d8) into main (c43fc4e) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head cbd19d8 differs from pull request most recent head 3943b7c. Consider uploading reports for the commit 3943b7c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
+ Coverage   75.07%   75.10%   +0.02%     
==========================================
  Files         183      183              
  Lines       11083    11083              
  Branches     2917     2917              
==========================================
+ Hits         8321     8324       +3     
+ Misses       2762     2759       -3     

see 2 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@rozenmd rozenmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@penalosa
Copy link
Copy Markdown
Contributor

penalosa commented Jun 23, 2023

I'm a bit concerned about the change in glob behaviour:

Globbing requires the --glob CLI option or glob option property to be set. (Removed in 4.0 and 4.1, opt-in support added in 4.2.)

Do we rely on that anywhere?

@JacobMGEvans
Copy link
Copy Markdown
Contributor Author

I'm a bit concerned about the change in glob behaviour:

Globbing requires the --glob CLI option or glob option property to be set. (Removed in 4.0 and 4.1, opt-in support added in 4.2.)

Do we rely on that anywhere?

Not that I could find. There is only really 2 places we use rimraf one is the direct script usage in Wrangler package.json and the 2nd is the ONLY one in the webpack package. @penalosa

@JacobMGEvans JacobMGEvans merged commit 3f61892 into main Jun 30, 2023
@JacobMGEvans JacobMGEvans deleted the jacobmgevans/upgrade-rimraf branch June 30, 2023 14:03
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants