Skip to content

C3: Fix the --version flag output#3500

Merged
jculvey merged 4 commits intomainfrom
c3-fix-version
Jun 22, 2023
Merged

C3: Fix the --version flag output#3500
jculvey merged 4 commits intomainfrom
c3-fix-version

Conversation

@jculvey
Copy link
Copy Markdown
Contributor

@jculvey jculvey commented Jun 20, 2023

Fixes #3495.

What this PR solves / how to test:

Makes it so running c3 with only the --version flag produces the correct output (just the version number)

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@jculvey jculvey requested review from a team, RamIdeas and petebacondarwin as code owners June 20, 2023 18:02
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: 3d03984

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5348184816/npm-package-wrangler-3500

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3500/npm-package-wrangler-3500

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5348184816/npm-package-wrangler-3500 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5348184816/npm-package-cloudflare-pages-shared-3500

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3500 (9074182) into main (fddffdf) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 9074182 differs from pull request most recent head 3d03984. Consider uploading reports for the commit 3d03984 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3500      +/-   ##
==========================================
- Coverage   75.20%   75.17%   -0.04%     
==========================================
  Files         183      183              
  Lines       11064    11062       -2     
  Branches     2906     2915       +9     
==========================================
- Hits         8321     8316       -5     
- Misses       2743     2746       +3     

see 7 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pretty straightforward to add a test for, right?

@jculvey
Copy link
Copy Markdown
Contributor Author

jculvey commented Jun 20, 2023

This should be pretty straightforward to add a test for, right?

for sure, good idea

@jculvey jculvey merged commit c43fc4e into main Jun 22, 2023
@jculvey jculvey deleted the c3-fix-version branch June 22, 2023 18:44
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: [C3] the --version param on create-cloudflare returns 0.0.0 and weird output

2 participants