fix(create-cloudflare): use wrangler deploy instead of wrangler publish#3486
Merged
petebacondarwin merged 3 commits intocloudflare:mainfrom Jun 21, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 6ed8af7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RamIdeas
approved these changes
Jun 17, 2023
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5330637794/npm-package-wrangler-3486You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3486/npm-package-wrangler-3486Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5330637794/npm-package-wrangler-3486 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5330637794/npm-package-cloudflare-pages-shared-3486Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3486 +/- ##
==========================================
+ Coverage 75.08% 75.10% +0.02%
==========================================
Files 183 183
Lines 11084 11084
Branches 2918 2918
==========================================
+ Hits 8322 8325 +3
+ Misses 2762 2759 -3 |
2bef5c6 to
1ae0fc6
Compare
1ae0fc6 to
6ed8af7
Compare
petebacondarwin
approved these changes
Jun 21, 2023
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # [insert GH or internal issue number(s)].
What this PR solves / how to test:
This fixes C3 scripts and READMEs to use the wrangler 3
deploycommand instead ofpublish.Author has included the following, where applicable:
Reviewer is to perform the following, as applicable: