fix: warn if the site.entry-point configuration is found during publishing#293
Conversation
🦋 Changeset detectedLatest commit: 6be9e85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0b928c6 to
80833a2
Compare
|
This should probably have a deprecation error, unless we already throw if we don't find an entry point? |
|
Currently we throw if there is neither a command line script nor a configured |
threepointone
left a comment
There was a problem hiding this comment.
one note, but looks good! we can iterate if needed.
|
I realised that the current flow might be a bit weird for those who have not set up other means for specifying entry-points. They will only receive an error "missing main file". 😢 |
80833a2 to
c1e4d12
Compare
c1e4d12 to
078523c
Compare
threepointone
left a comment
There was a problem hiding this comment.
I appreciate the tests here deeply, thank you!
fe20aed to
cf70bd0
Compare
…lishing Also updates the message and adds a test for the error when there is no entry-point specified. Fixes cloudflare#282
cf70bd0 to
6be9e85
Compare
Is it enough to log a warning? Or should we throw a
new DeprecationError()?Fixes #282