Skip to content

fix(wrangler): version listing limits#14165

Merged
NuroDev merged 2 commits into
mainfrom
fix/versions-list-limit
Jun 2, 2026
Merged

fix(wrangler): version listing limits#14165
NuroDev merged 2 commits into
mainfrom
fix/versions-list-limit

Conversation

@NuroDev

@NuroDev NuroDev commented Jun 2, 2026

Copy link
Copy Markdown
Member

Fixes #14160.

This change updates the wrangler versions list command to only show 10 version rather than 100, which the API now defaults to.

Note

The API does not allow for both deployable=true and per_page=10 parameters together. So we filter the versions list client-sode.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: CLI bug fix

A picture of a cute animal (not mandatory, but encouraged)

@NuroDev NuroDev self-assigned this Jun 2, 2026
@changeset-bot

changeset-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: db755e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
@cloudflare/wrangler-bundler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jun 2, 2026
@ask-bonk

ask-bonk Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

number: number — the mock uses a numeric value, type-correct. Good.

Now let me verify the real correctness concern with the non-JSON path and ordering. The change applies the slice to both JSON and table output. The sort orders ascending (oldest first), which preserves the existing display order. Both correct.

Let me consider one genuine issue: the PR note says the API "now defaults to 100". But fetchDeployableVersions doesn't send per_page at all and the API ignores pagination for deployable=true. So the only reliable cap is the client-side slice — which this PR does correctly. No backward-compat or logic break.

Let me verify there are no other callers of fetchDeployableVersions that would be affected — the slice is in list.ts handler only, not in the shared API function, so other callers are unaffected. Confirmed from api.ts; the function itself is unchanged.

The implementation is correct, well-tested (verifies per_page is not sent, verifies the 10 most recent are returned), and the changeset is appropriate. The sort + slice correctly yields the 10 most recent in ascending display order, matching prior behavior.

I find no logic bugs, security issues, backward-compatibility violations, or incorrect API behavior.

LGTM

github run

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new

pkg-pr-new Bot commented Jun 2, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14165

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14165

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14165

miniflare

npm i https://pkg.pr.new/miniflare@14165

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14165

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14165

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14165

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14165

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14165

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14165

wrangler

npm i https://pkg.pr.new/wrangler@14165

@cloudflare/wrangler-bundler

npm i https://pkg.pr.new/@cloudflare/wrangler-bundler@14165

commit: db755e0

@NuroDev NuroDev marked this pull request as ready for review June 2, 2026 19:03
@NuroDev NuroDev requested a review from workers-devprod as a code owner June 2, 2026 19:03
@NuroDev NuroDev enabled auto-merge (squash) June 2, 2026 19:04
@workers-devprod workers-devprod requested review from a team and dario-piotrowicz and removed request for a team June 2, 2026 19:04
@workers-devprod

workers-devprod commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Jun 2, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

dario-piotrowicz
dario-piotrowicz approved these changes Jun 2, 2026
View reviewed changes

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

workers-devprod
workers-devprod approved these changes Jun 2, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@NuroDev NuroDev merged commit 8400fb9 into main Jun 2, 2026
62 of 63 checks passed
@NuroDev NuroDev deleted the fix/versions-list-limit branch June 2, 2026 22:22
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 2, 2026
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 2, 2026
@workers-devprod workers-devprod mentioned this pull request Jun 2, 2026
Merged
@Lp-Francois

Lp-Francois commented Jun 3, 2026

Copy link
Copy Markdown

Wow that was fast. Thanks @NuroDev ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes
@workers-devprod workers-devprod workers-devprod approved these changes

Assignees

@NuroDev NuroDev

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wrangler versions list returns more than 10 versions

4 participants

@NuroDev @workers-devprod @Lp-Francois @dario-piotrowicz