[wrangler] fix: remove trailing period after api-tokens URL in wrangler whoami output#14133
Merged
Merged
Conversation
… output Fixes cloudflare#14102. The message "To see token permissions visit https://.../api-tokens." ended with a period that was included in the URL when clicked from terminals and GitHub Actions output, causing a 404. Move the sentence punctuation before "visit" (adding a comma) so the URL has no trailing period.
🦋 Changeset detectedLatest commit: 4b6af21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes a trailing period from the wrangler whoami token-permissions URL so terminals/GitHub Actions don’t include punctuation in the clickable link (preventing 404s).
Changes:
- Update
whoamioutput string to remove trailing.and improve sentence flow. - Update deploy snapshot to match the new output.
- Add a changeset documenting the patch.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/wrangler/src/user/whoami.ts | Adjusts the logged URL so it’s not polluted by trailing punctuation. |
| packages/wrangler/src/tests/deploy/core.test.ts | Updates snapshot expectation to match the new log output. |
| .changeset/whoami-trailing-period.md | Adds a patch changeset explaining the fix and why it matters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
@cloudflare/wrangler-bundler
commit: |
penalosa
approved these changes
Jun 1, 2026
workers-devprod
approved these changes
Jun 1, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14102.
What this does
wrangler whoamiwas printing:The trailing
.became part of the URL when clicked in terminals andGitHub Actions output, causing a 404.
Before:
...api-tokens.(period is part of the clickable URL)After:
...api-tokens(period removed; comma added before "visit")Tests
deploy/core.test.ts; all 20whoami.test.tstests passDocumentation