[wrangler] Fix autoconfig for Vite projects without a config file by MattieTK · Pull Request #14074 · cloudflare/workers-sdk

MattieTK · 2026-05-27T23:26:42Z

wrangler setup crashed with "Could not find Vite config file to modify" for Vite projects that have no vite.config.js or vite.config.ts. Vite does not require a config file for simple projects, so several create-vite templates omit it entirely.

When no config file exists, autoconfig now creates a minimal one with the Cloudflare plugin already configured. isConfigured() also returns false instead of throwing.

The fix is scoped to the Vite framework class only. Other frameworks that use the shared transformViteConfig utility (React Router, TanStack) are unaffected -- they always have a config file, and the existing throw behaviour is correct for them.

Affected templates (6 of 16): vanilla, vanilla-ts, react-swc, react-swc-ts, lit, lit-ts

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: this is a bug fix to existing behaviour, no new user-facing configuration

Known issue: create-vite --template solid detected as Static instead of Vite

@netlify/build-info correctly identifies plain Solid projects as solid-js (distinct from solid-start). However, wrangler's allKnownFrameworks list has solid-start but not solid-js, so getFrameworkClassInstance falls back to the Static handler. This means plain Solid SPAs get assets.directory without not_found_handling: "single-page-application", which would cause 404s on client-side routes.

This is a separate issue from the config file fix in this PR. A follow-up could add fallback logic in the autoconfig layer: when an unknown framework is detected but the project has vite as a dependency and uses vite build, route it through the Vite handler instead of Static.

Vite projects scaffolded without a vite.config file (e.g. create-vite vanilla, react-swc, lit templates) failed with 'Could not find Vite config file to modify'. When no config file exists, autoconfig now generates a minimal one with the Cloudflare plugin already wired in. The Vite.isConfigured() method also returns false instead of throwing in this case. The fix is scoped to the Vite framework class. Other frameworks that use the shared vite-config utilities (React Router, TanStack) still get the existing throw behaviour, which is correct for them.

changeset-bot · 2026-05-27T23:26:46Z

🦋 Changeset detected

Latest commit: fbac515

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod · 2026-05-27T23:27:06Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

ask-bonk · 2026-05-27T23:28:37Z

React Router and TanStack both call transformViteConfig directly without a hasViteConfig guard — but as the PR description says, these frameworks always ship with config files (they're part of the framework scaffolding), so the existing throw behavior in getViteConfigPath is appropriate for them.

Now I have a thorough understanding. Let me check one more thing — the changeset file references only wrangler, which is correct since all changed files are in the wrangler package. The changeset-bot message about 3 packages is likely due to other changesets on the branch or pre-existing changesets, not this PR's changeset.

Let me look at one potential issue more carefully — the dryRun test:

In the dry-run test (line 89-105), dryRun: true means neither installCloudflareVitePlugin nor createViteConfig is called. The test asserts no config file is created AND the correct wranglerConfig is returned. But notice that installPackages is still mocked via vi.spyOn in beforeEach. Even if dryRun weren't guarding the call, the mock would prevent real installation. This is correct test structure.

However, I notice one thing: the test at line 89 does NOT mock installCloudflareVitePlugin (unlike the vike test which uses vi.mock). The vite test relies on the vi.spyOn(cliPackages, "installPackages") mock to catch package installs. Since installCloudflareVitePlugin internally calls installPackages, the spy would catch it. And with dryRun: true, installCloudflareVitePlugin isn't called at all. This is fine.

I'm satisfied with my review. The code changes are clean, correct, and well-scoped. The logic is sound:

isConfigured() now gracefully returns false instead of throwing when no config exists
configure() creates a minimal config file when none exists, using the correct extension
The dryRun guard correctly prevents both installation and file creation
Tests cover the main scenarios adequately
The changeset is correct

LGTM

github run

github-actions · 2026-05-27T23:31:11Z

✅ All changesets look good

pkg-pr-new · 2026-05-27T23:36:36Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14074

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14074

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14074

miniflare

npm i https://pkg.pr.new/miniflare@14074

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14074

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14074

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14074

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14074

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14074

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14074

wrangler

npm i https://pkg.pr.new/wrangler@14074

commit: fbac515

dario-piotrowicz

LGTM

I also prefer this simpler PR for fixing this compared to #14073 (which is anyways still in draft)

I think that anyways some aspects of 14073 are however good and should be still included (as a followup) such as checking whether the vite config file is cjs.

workers-devprod

Codeowners reviews satisfied

MattieTK requested a review from workers-devprod as a code owner May 27, 2026 23:26

workers-devprod added this to workers-sdk May 27, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk May 27, 2026

workers-devprod requested review from a team and ascorbic and removed request for a team May 27, 2026 23:27

dario-piotrowicz approved these changes May 28, 2026

View reviewed changes

workers-devprod approved these changes May 28, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 28, 2026

MattieTK merged commit 37176e5 into main May 28, 2026
65 of 66 checks passed

github-project-automation Bot moved this from Approved to Done in workers-sdk May 28, 2026

MattieTK deleted the fix/autoconfig-vite-no-config-file branch May 28, 2026 09:51

workers-devprod mentioned this pull request May 27, 2026

Version Packages #14048

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[wrangler] Fix autoconfig for Vite projects without a config file#14074

[wrangler] Fix autoconfig for Vite projects without a config file#14074
MattieTK merged 1 commit into
mainfrom
fix/autoconfig-vite-no-config-file

MattieTK commented May 27, 2026

Uh oh!

changeset-bot Bot commented May 27, 2026

Uh oh!

workers-devprod commented May 27, 2026 •

edited

Loading

Uh oh!

ask-bonk Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

pkg-pr-new Bot commented May 27, 2026

Uh oh!

dario-piotrowicz left a comment

Uh oh!

workers-devprod left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

MattieTK commented May 27, 2026

Uh oh!

changeset-bot Bot commented May 27, 2026

🦋 Changeset detected

Uh oh!

workers-devprod commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ask-bonk Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

pkg-pr-new Bot commented May 27, 2026

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

workers-devprod left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

workers-devprod commented May 27, 2026 •

edited

Loading