Skip to content

[wrangler] Add confirmation prompt to containers images delete#14071

Merged
dario-piotrowicz merged 2 commits into
cloudflare:mainfrom
sherryliu-lsy:sherryliu/containers-image-delete-confirmation
May 28, 2026
Merged

[wrangler] Add confirmation prompt to containers images delete#14071
dario-piotrowicz merged 2 commits into
cloudflare:mainfrom
sherryliu-lsy:sherryliu/containers-image-delete-confirmation

Conversation

@sherryliu-lsy

@sherryliu-lsy sherryliu-lsy commented May 27, 2026

Copy link
Copy Markdown
Contributor

Fixes CC-6324 - wrangler: confirmation prompt before deleting an image from the registry

Add a confirmation prompt to wrangler containers images delete before deleting an image from the Cloudflare managed registry. Previously the command would delete immediately with no confirmation.

Users can bypass the prompt with --skip-confirmation or -y for scripted/non-interactive environments.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: confirmation prompt is self-explanatory from the CLI help output

Open in Devin Review

@changeset-bot

changeset-bot Bot commented May 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 01ee7e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod requested review from a team and petebacondarwin and removed request for a team May 27, 2026 21:21
@workers-devprod

workers-devprod commented May 27, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new

pkg-pr-new Bot commented May 27, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14071

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14071

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14071

miniflare

npm i https://pkg.pr.new/miniflare@14071

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14071

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14071

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14071

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14071

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14071

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14071

wrangler

npm i https://pkg.pr.new/wrangler@14071

commit: 01ee7e5

Comment thread packages/wrangler/src/containers/images.ts

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 28, 2026
@dario-piotrowicz dario-piotrowicz merged commit f623ae4 into cloudflare:main May 28, 2026
73 of 75 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants