[vitest-pool-workers] Dispatch RPC methods through proxied Durable Object instances#14070
Merged
dario-piotrowicz merged 2 commits intoMay 28, 2026
Conversation
🦋 Changeset detectedLatest commit: 0057484 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
workers-devprod
approved these changes
May 27, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Durable Object export may return a
Proxyfrom its constructor to mediate public RPC method access, for example to bind wrapped methods to the original instance.@cloudflare/vitest-pool-workerscurrently validates and retrieves RPC methods directly from the constructor prototype, then binds the raw method to the returned proxy. This bypasses the proxy'sgettrap and causes methods using ECMAScript private fields or methods to throw a receiver-brandTypeError.This changes Durable Object RPC resolution to continue validating prototype visibility first, but then retrieve an allowed method through the constructed instance so proxy wrappers can mediate it. Constructor-assigned own overrides remain rejected, matching native
workerdbehavior rather than exposing arbitrary instance methods.The RPC fixture now covers:
I additionally checked both behaviors through
wrangler dev/nativeworkerd: the proxy-mediated private-field method succeeds, while the constructor-assigned method override is rejected.A picture of a cute animal (not mandatory, but encouraged)