IMAGES-2139: update images binding to chainable handle pattern#13128
Closed
mglewis wants to merge 1 commit intocloudflare:mainfrom
Closed
IMAGES-2139: update images binding to chainable handle pattern#13128mglewis wants to merge 1 commit intocloudflare:mainfrom
mglewis wants to merge 1 commit intocloudflare:mainfrom
Conversation
- images.worker.ts: replace flat methods with ImageHandleImpl (RpcTarget) and synchronous image(imageId) factory on the service entrypoint - index.spec.ts: update tests to use new handle API - ts-expect-error annotations pending workerd PR cloudflare#6288 types landing
🦋 Changeset detectedLatest commit: ad26e7c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Contributor
Contributor
|
Bundling these changes into #13241 |
Member
Author
|
Hi folks, sorry for missing this one. Thanks for cleaning up my mess for me 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per cloudflare/workerd#6288 we are updating the interface of the images binding to use a chainable handle. This change is the counterpart for workers-sdk that uses the new types and implementation.
This change will be taken out of draft after 6288 has been merged, before then we expect CI failures.
Summary of changes
images.worker.ts: replace flat methods withImageHandleImpl(RpcTarget) and synchronousimage(imageId)factory on the service entrypointindex.spec.ts: update tests to use new handle APIts-expect-errorannotations pending workerd PR 🐛 BUG: wrangler pages deploy throws misleading error when experimental:nodejs_compat_v2 is enabled #6288 types landingFixes https://jira.cfdata.org/browse/IMAGES-2139
A picture of a cute animal (not mandatory, but encouraged)
