Skip to content

Filter compatibility date fallback warning when no update is available#12400

Merged
dario-piotrowicz merged 10 commits into
mainfrom
dario/DEVX-2442/suppress-date-fallback-vite-latest
May 27, 2026
Merged

Filter compatibility date fallback warning when no update is available#12400
dario-piotrowicz merged 10 commits into
mainfrom
dario/DEVX-2442/suppress-date-fallback-vite-latest

Conversation

@dario-piotrowicz

@dario-piotrowicz dario-piotrowicz commented Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes https://jira.cfdata.org/browse/DEVX-2442

This PR updates the compatibility date warning from workerd (e.g., "The latest compatibility date supported by the installed Cloudflare Workers Runtime is...") so that now is only shown when a newer version of @cloudflare/vite-plugin is available. This matches the behavior in Wrangler and reduces noise when the user is already on the latest version.

Note

This PR was fully authored by Claude Opus 4.5, I've reviewed the changes

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this is a minimal DX improvement (this breaking won't significantly impact users), this is also not tested in wrangler (I'm happy to add tests both for the vite plugin and wrangler is people feel that this should have tests)
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: DX improvement

A picture of a cute animal (not mandatory, but encouraged)

Open with Devin

@changeset-bot

changeset-bot Bot commented Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ff6fa5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/vite-plugin Patch
@cloudflare/workers-utils Patch
@cloudflare/cli-shared-helpers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Feb 3, 2026
@claude

claude Bot commented Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Claude finished @dario-piotrowicz's task —— View job

Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Check for cute animal image
  • Post validation results

✅ All changesets look good

The changeset for @cloudflare/vite-plugin is properly formatted:

  • Version Type: Patch is appropriate for a DX improvement that filters warnings
  • Changelog Quality: Clear description with context about matching Wrangler behavior
  • Markdown Headers: No problematic h1/h2/h3 headers used
  • Format: Follows the recommended title + body structure

@pkg-pr-new

pkg-pr-new Bot commented Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12400

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@12400

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12400

miniflare

npm i https://pkg.pr.new/miniflare@12400

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12400

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12400

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12400

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12400

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12400

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12400

wrangler

npm i https://pkg.pr.new/wrangler@12400

commit: ff6fa5e

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2442/suppress-date-fallback-vite-latest branch from 490b418 to 4dcc736 Compare February 4, 2026 00:03
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review February 4, 2026 00:10
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner February 4, 2026 00:10
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@vicb

vicb commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Fixes https://jira.cfdata.org/browse/DEVX-2442

Could you please add a short description of what the PR changes?

vicb
vicb reviewed Feb 4, 2026
View reviewed changes
Comment thread packages/vite-plugin-cloudflare/src/miniflare-options.ts Outdated
vicb
vicb reviewed Feb 4, 2026
View reviewed changes
Comment thread packages/vite-plugin-cloudflare/src/miniflare-options.ts Outdated
vicb
vicb reviewed Feb 4, 2026
View reviewed changes
Comment thread packages/vite-plugin-cloudflare/src/update-check.ts Outdated
vicb
vicb reviewed Feb 4, 2026
View reviewed changes
Comment thread packages/vite-plugin-cloudflare/src/update-check.ts
vicb
vicb reviewed Feb 4, 2026
View reviewed changes
Comment thread packages/vite-plugin-cloudflare/src/miniflare-options.ts Outdated
vicb
vicb reviewed Feb 4, 2026
View reviewed changes
Comment thread packages/vite-plugin-cloudflare/src/miniflare-options.ts Outdated
@petebacondarwin

petebacondarwin commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

@dario-piotrowicz - this PR needs a rebase and has lots of requests for changes. Do you want to get it over the line? If not perhaps close it or mark it draft?

@dario-piotrowicz dario-piotrowicz marked this pull request as draft April 21, 2026 09:11
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2442/suppress-date-fallback-vite-latest branch 2 times, most recently from eee0f84 to d74838a Compare April 26, 2026 16:03
@github-actions

github-actions Bot commented Apr 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review April 26, 2026 17:00
@workers-devprod

workers-devprod commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/vite-plugin-cloudflare/src/miniflare-options.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/update-check.ts: [@cloudflare/wrangler]
  • packages/workers-utils/package.json: [@cloudflare/wrangler]
  • packages/workers-utils/src/index.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/update-check.ts: [@cloudflare/wrangler]
  • packages/wrangler/package.json: [@cloudflare/wrangler]
  • packages/wrangler/src/update-check.ts: [@cloudflare/wrangler]
  • pnpm-lock.yaml: [@cloudflare/wrangler]

@dario-piotrowicz dario-piotrowicz requested a review from vicb April 27, 2026 09:01
vicb
vicb reviewed May 5, 2026
View reviewed changes

@vicb vicb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments

Comment thread packages/vite-plugin-cloudflare/src/miniflare-options.ts Outdated
Comment thread packages/vite-plugin-cloudflare/src/miniflare-options.ts Outdated
Comment thread packages/workers-utils/src/update-check.ts Outdated
Comment thread packages/workers-utils/src/update-check.ts Outdated
Comment thread packages/workers-utils/src/update-check.ts Outdated
Comment thread packages/vite-plugin-cloudflare/src/update-check.ts Outdated
Comment thread packages/vite-plugin-cloudflare/src/update-check.ts Outdated
@workers-devprod

workers-devprod commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

vicb
vicb reviewed May 5, 2026
View reviewed changes
Comment thread packages/workers-utils/src/update-check.ts Outdated
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

vicb
vicb reviewed May 5, 2026
View reviewed changes
Comment thread packages/workers-utils/src/update-check.ts Outdated
vicb
vicb reviewed May 5, 2026
View reviewed changes
Comment thread packages/workers-utils/src/update-check.ts
vicb
vicb reviewed May 5, 2026
View reviewed changes
Comment thread packages/workers-utils/src/update-check.ts Outdated
vicb
vicb approved these changes May 5, 2026
View reviewed changes

@vicb vicb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to approve earlier as all my comments are minor

workers-devprod
workers-devprod approved these changes May 5, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 5, 2026
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2442/suppress-date-fallback-vite-latest branch from e940053 to ff6fa5e Compare May 27, 2026 13:25
@workers-devprod

workers-devprod commented May 27, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@dario-piotrowicz dario-piotrowicz merged commit d4177ce into main May 27, 2026
64 of 65 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2442/suppress-date-fallback-vite-latest branch May 27, 2026 15:09
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 27, 2026
@workers-devprod workers-devprod mentioned this pull request May 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@vicb vicb vicb approved these changes
@workers-devprod workers-devprod workers-devprod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dario-piotrowicz @vicb @petebacondarwin @workers-devprod