Skip to content

Fix remote dev with Access#10938

Merged
penalosa merged 1 commit intomainfrom
penalosa/fix-remote-dev-access
Oct 13, 2025
Merged

Fix remote dev with Access#10938
penalosa merged 1 commit intomainfrom
penalosa/fix-remote-dev-access

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Oct 9, 2025 •
edited by devin-ai-integration bot
Loading

Too many internal details are involved to give an effective summary, but suffice to say that wrangler dev --remote has been broken against Cloudflare Access protected domains for a few weeks. This PR fixes that by adding Access tokens to more requests made during a wrangler dev --remote session.

  • Tests
    • Tests included
    • Tests not necessary because: This involves Cloudflare Access and so needs to be manually verified. In theory we could add an E2E test for this, but given the current length and flakiness of the suite I'm hesitant to do that. @penalosa has manually verified this fixes the issue against a test Access application.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 420d73c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Oct 9, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 9, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10938

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10938

miniflare

npm i https://pkg.pr.new/miniflare@10938

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10938

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10938

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10938

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10938

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10938

wrangler

npm i https://pkg.pr.new/wrangler@10938

commit: 420d73c

JoaquinGimenez1
JoaquinGimenez1 approved these changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JoaquinGimenez1 JoaquinGimenez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vicb
vicb approved these changes Oct 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 10, 2025
@vicb vicb marked this pull request as ready for review October 10, 2025 16:06
@vicb vicb requested a review from a team as a code owner October 10, 2025 16:06
@penalosa penalosa linked an issue Oct 13, 2025 that may be closed by this pull request
Error: Could not create remote preview session on your account #10773
Closed
@devin-ai-integration devin-ai-integration bot mentioned this pull request Oct 13, 2025
Merged
7 tasks
@penalosa penalosa force-pushed the penalosa/fix-remote-dev-access branch from 076e78c to 420d73c Compare October 13, 2025 12:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 13, 2025

These changes have been automatically backported to Wrangler v3 🎉 You can view the automatically updated PR at v3-maintenance...v3-backport-10938. Please check that PR for correctness, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported!

@penalosa penalosa merged commit e52d0ec into main Oct 13, 2025
44 of 48 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 13, 2025
@penalosa penalosa deleted the penalosa/fix-remote-dev-access branch October 13, 2025 22:08
@workers-devprod workers-devprod mentioned this pull request Oct 13, 2025
Merged
@AndreasMadsen AndreasMadsen mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

+1 more reviewer

@JoaquinGimenez1 JoaquinGimenez1 JoaquinGimenez1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Could not create remote preview session on your account

4 participants

@penalosa @vicb @JoaquinGimenez1 @workers-devprod