Skip to content

Fix remote/local display#10674

Merged
penalosa merged 2 commits intomainfrom
penalosa/remote-bindings-local
Sep 17, 2025
Merged

Fix remote/local display#10674
penalosa merged 2 commits intomainfrom
penalosa/remote-bindings-local

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Sep 16, 2025

Fixes two minor display bugs:

  • Browser bindings incorrectly showed a warning about not supporting local mode
  • KV/R2/D1 bindings did not respect the REMOTE_BINDINGS flag when displaying their remote/local status
  • Tests
    • Tests included
    • Tests not necessary because: minor display issues
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor display issues
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a v3 feature

@penalosa penalosa requested a review from a team as a code owner September 16, 2025 13:55
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6c44d8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 16, 2025
@penalosa penalosa force-pushed the penalosa/remote-bindings-local branch from 6b3dc2b to 44a2935 Compare September 16, 2025 13:55
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 16, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10674

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10674

miniflare

npm i https://pkg.pr.new/miniflare@10674

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10674

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10674

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10674

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10674

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10674

wrangler

npm i https://pkg.pr.new/wrangler@10674

commit: 6c44d8c

dario-piotrowicz
dario-piotrowicz approved these changes Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there also be a changeset? 🤔

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 16, 2025
@penalosa penalosa merged commit 1cc258e into main Sep 17, 2025
61 of 69 checks passed
@penalosa penalosa deleted the penalosa/remote-bindings-local branch September 17, 2025 11:48
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 17, 2025
@workers-devprod workers-devprod mentioned this pull request Sep 17, 2025
Merged
@zalmanlew
Copy link
Copy Markdown

zalmanlew commented Sep 18, 2025

@penalosa thanks for this - seems to still be showing remote for ratelimit bindings
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@penalosa @zalmanlew @dario-piotrowicz @workers-devprod