Skip to content

Avoid mutating the Worker config during build.#10664

Merged
jamesopstad merged 3 commits intomainfrom
james/immutable-config
Sep 16, 2025
Merged

Avoid mutating the Worker config during build.#10664
jamesopstad merged 3 commits intomainfrom
james/immutable-config

Conversation

@jamesopstad
Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad commented Sep 15, 2025 •
edited
Loading

Fixes #10650.

This fixes an issue that can occur if the same Worker environment is built twice.

  • Tests
    • Tests included
    • Tests not necessary because
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a Wrangler change

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1f8e235

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 15, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 15, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10664

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10664

miniflare

npm i https://pkg.pr.new/miniflare@10664

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10664

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10664

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10664

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10664

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10664

wrangler

npm i https://pkg.pr.new/wrangler@10664

commit: 1f8e235

@jamesopstad jamesopstad force-pushed the james/immutable-config branch from beefe44 to 3f258a1 Compare September 15, 2025 21:01
@jamesopstad jamesopstad marked this pull request as ready for review September 15, 2025 21:02
@jamesopstad jamesopstad requested a review from a team September 15, 2025 21:02
@jamesopstad jamesopstad requested a review from a team as a code owner September 15, 2025 21:02
dario-piotrowicz
dario-piotrowicz approved these changes Sep 16, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 16, 2025
@jamesopstad jamesopstad force-pushed the james/immutable-config branch from 3f258a1 to 1f8e235 Compare September 16, 2025 13:36
@jamesopstad jamesopstad merged commit 924fdde into main Sep 16, 2025
52 of 59 checks passed
@jamesopstad jamesopstad deleted the james/immutable-config branch September 16, 2025 15:44
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 16, 2025
@workers-devprod workers-devprod mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@vitejs/plugin-rsc build fails with @cloudflare/vite-plugin since v1.13.0

3 participants

@jamesopstad @dario-piotrowicz @workers-devprod