fix: update R2 SQL response format and env variable#10654
Merged
dario-piotrowicz merged 3 commits intomainfrom Sep 16, 2025
Merged
fix: update R2 SQL response format and env variable#10654dario-piotrowicz merged 3 commits intomainfrom
dario-piotrowicz merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 68287d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
penalosa
approved these changes
Sep 15, 2025
packages/wrangler/src/r2/sql.ts
Outdated
Comment on lines
84
to
86
Contributor
There was a problem hiding this comment.
What about const token = getWranglerR2SqlAuthToken() ?? getCloudflareAPITokenFromEnv()?
Contributor
Author
There was a problem hiding this comment.
We could do that! The only thing is I want to keep the warning log about the fallback. I don't think that behaviour is super clear to the user and it would be great to have some way to notify them
sejoker
approved these changes
Sep 15, 2025
846c97f to
68287d3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes env variable used for R2 SQL token from
CLOUDFLARE_API_TOKENtoWRANGLER_R2_SQL_AUTH_TOKEN. It also updates thequerycommand to use the latest version of response from R2 SQL service.Approval: CR-1298405