Skip to content

improve diff lines ordering in remote deploy config diffing logic#10401

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/config-diff-sorting
Sep 1, 2025
Merged

improve diff lines ordering in remote deploy config diffing logic#10401
dario-piotrowicz merged 1 commit intomainfrom
dario/config-diff-sorting

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

Fixes #10362

Example diff log when the current config removed a variable set in the dashboard:

Before After
Screenshot 2025-08-18 at 16 58 16 Screenshot 2025-08-18 at 16 54 42
Notice how the + line is weirdly positioned, making the diff much less readable All the - lines are now together making the diff much cleaner and more readable

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: updates to a non-v3 feature

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 18, 2025

🦋 Changeset detected

Latest commit: ea1caff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Aug 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10401

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10401

miniflare

npm i https://pkg.pr.new/miniflare@10401

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10401

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10401

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10401

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10401

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10401

wrangler

npm i https://pkg.pr.new/wrangler@10401

commit: ea1caff

@dario-piotrowicz dario-piotrowicz force-pushed the dario/config-diff-sorting branch from 2304505 to ea1caff Compare August 29, 2025 14:54
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review August 30, 2025 12:11
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners August 30, 2025 12:11
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 1, 2025
@dario-piotrowicz dario-piotrowicz merged commit 3c15bbb into main Sep 1, 2025
54 of 72 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/config-diff-sorting branch September 1, 2025 13:06
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

improve remote check diffs lines ordering/grouping

3 participants