[wrangler] fix: prevent multiple workflows definition with same name#10179
Merged
pombosilva merged 3 commits intomainfrom Aug 7, 2025
Merged
[wrangler] fix: prevent multiple workflows definition with same name#10179pombosilva merged 3 commits intomainfrom
pombosilva merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7b0363c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
These changes have been automatically backported to Wrangler v3 🎉 You can view the automatically updated PR at v3-maintenance...v3-backport-10179. Please check that PR for correctness, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported! |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
8b17304 to
b4e18f4
Compare
petebacondarwin
requested changes
Aug 4, 2025
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Thanks for adding this @pombosilva - can you add a test for it somewhere... I know we discussed the fact that the other workflow stuff is tested separately to the standard config validation code.
06b751a to
8b6f00b
Compare
petebacondarwin
approved these changes
Aug 5, 2025
petebacondarwin
approved these changes
Aug 6, 2025
bff8dd2 to
ac04b76
Compare
ac04b76 to
7b0363c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WOR-795
Users should not be allowed to define multiple workflows with the same "name" property within a single Wrangler jsonc/toml file. If duplicate names are allowed, only the last-defined workflow would be active, as it would overwrite any earlier workflows with the same name.
To fix this, the code now includes a check for duplicate "name" properties within the workflows array.