Skip to content

refactor: add page.goto() back into beforeEach#10140

Closed
petebacondarwin wants to merge 2 commits intomainfrom
pbd/dot-env-cleanup-4
Closed

refactor: add page.goto() back into beforeEach#10140
petebacondarwin wants to merge 2 commits intomainfrom
pbd/dot-env-cleanup-4

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jul 30, 2025 •
edited
Loading

Will remove gotos from individual tests if this doesn't fail CI.

@petebacondarwin petebacondarwin added skip-pr-description-validation Skip validation of the required PR description format no-changeset-required skip-v3-pr labels Jul 30, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cf7baf0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jul 30, 2025
@petebacondarwin petebacondarwin mentioned this pull request Jul 30, 2025
Merged
7 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 30, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10140

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10140

miniflare

npm i https://pkg.pr.new/miniflare@10140

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10140

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10140

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10140

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10140

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10140

wrangler

npm i https://pkg.pr.new/wrangler@10140

commit: cf7baf0

@petebacondarwin petebacondarwin force-pushed the pbd/dot-env-cleanup-4 branch from 3e5e905 to cf7baf0 Compare July 30, 2025 21:17
@petebacondarwin petebacondarwin marked this pull request as ready for review July 30, 2025 21:33
@petebacondarwin petebacondarwin requested a review from a team July 30, 2025 21:33
@petebacondarwin petebacondarwin requested a review from a team as a code owner July 30, 2025 21:33
@petebacondarwin
Copy link
Contributor Author

petebacondarwin commented Jul 31, 2025

@jamesopstad and I agreed not to land this. It is nice to be explicit in the tests if you need a step to have moved the browser to the starting page.

@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changeset-required skip-pr-description-validation Skip validation of the required PR description format

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@petebacondarwin