Skip to content

Revert "Resolve dockerfile path based on original, non-redirected config path"#10037

Merged
emily-shen merged 1 commit intomainfrom
revert-10005-emily/dockerfile-resolution-again
Jul 22, 2025
Merged

Revert "Resolve dockerfile path based on original, non-redirected config path"#10037
emily-shen merged 1 commit intomainfrom
revert-10005-emily/dockerfile-resolution-again

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

Reverts #10005

Since the dockerfile is usually given as a relative path, it is not really correct to leave it as is in the redirected deploy config. Instead, we'll resolve the path to an absolute one and use that in the redirected config.

@emily-shen emily-shen requested review from a team as code owners July 22, 2025 09:38
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 22, 2025

⚠️ No Changeset found

Latest commit: a4e8b66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen added the skip-pr-description-validation Skip validation of the required PR description format label Jul 22, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jul 22, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jul 22, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10037

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10037

miniflare

npm i https://pkg.pr.new/miniflare@10037

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10037

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10037

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10037

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10037

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10037

wrangler

npm i https://pkg.pr.new/wrangler@10037

commit: a4e8b66

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 22, 2025
@emily-shen emily-shen merged commit 08b37f8 into main Jul 22, 2025
41 of 44 checks passed
@emily-shen emily-shen deleted the revert-10005-emily/dockerfile-resolution-again branch July 22, 2025 09:42
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants