fix(wrangler): show correct port in scheduled worker warning (#11494)

jalmonter · NuroDev · web-flow · commit ed60c4f01c0e · 2026-01-09T16:11:24.000Z
* fix(wrangler): show correct port in scheduled worker warning

* test: warn about scheduled workers with the correct port

* chore: add changeset

* test: warn about scheduled workers with the correct port

* test: warn about scheduled workers with the correct port

* Fixed e2e tests worker hostnames

* Fixed minor code formatting issue

---------

Co-authored-by: Ben &lt;4991309+NuroDev@users.noreply.github.com&gt;
Co-authored-by: Ben Dixon &lt;ben@nuro.dev&gt;
diff --git a/.changeset/chubby-spoons-learn.md b/.changeset/chubby-spoons-learn.md
@@ -0,0 +1,10 @@
+---
+"miniflare": patch
+"wrangler": patch
+---
+
+Fix scheduled trigger warning showing `undefined` port
+
+When running `wrangler dev` with a worker that has cron triggers, the warning message displayed an invalid URL like `curl "http://localhost:undefined/cdn-cgi/handler/scheduled"` because the port wasn't yet determined when the warning was logged.
+
+Moved the warning to after the proxy server is fully ready, where the actual public URL and port are known.
diff --git a/packages/wrangler/e2e/dev.test.ts b/packages/wrangler/e2e/dev.test.ts
@@ -234,6 +234,89 @@ describe.each([
 		});
 	});
 
+	describe(`scheduled worker warning with ${cmd}`, () => {
+		it("shows warning with correct port when cron trigger is configured", async () => {
+			const helper = new WranglerE2ETestHelper();
+			await helper.seed({
+				"wrangler.toml": dedent`
+								name = "${workerName}"
+								main = "src/index.ts"
+								compatibility_date = "2023-01-01"
+
+								[triggers]
+								crons = ["* * * * *"]
+						`,
+				"src/index.ts": dedent`
+								export default {
+									fetch(request) {
+										return new Response("Hello World!")
+									},
+									scheduled(event) {
+										console.log("Scheduled event triggered");
+									}
+								}`,
+				"package.json": dedent`
+								{
+									"name": "worker",
+									"version": "0.0.0",
+									"private": true
+								}
+								`,
+			});
+			const worker = helper.runLongLived(cmd);
+
+			const { url } = await worker.waitForReady();
+			const { hostname, port } = new URL(url);
+
+			// The warning should contain the actual port, not "undefined"
+			expect(worker.currentOutput).toContain(
+				"Scheduled Workers are not automatically triggered"
+			);
+			expect(worker.currentOutput).toContain(
+				`curl "http://${hostname}:${port}/cdn-cgi/handler/scheduled"`
+			);
+			expect(worker.currentOutput).not.toContain("undefined");
+		});
+
+		it("does not show warning when --test-scheduled is enabled", async () => {
+			const helper = new WranglerE2ETestHelper();
+			await helper.seed({
+				"wrangler.toml": dedent`
+								name = "${workerName}"
+								main = "src/index.ts"
+								compatibility_date = "2023-01-01"
+
+								[triggers]
+								crons = ["* * * * *"]
+						`,
+				"src/index.ts": dedent`
+								export default {
+									fetch(request) {
+										return new Response("Hello World!")
+									},
+									scheduled(event) {
+										console.log("Scheduled event triggered");
+									}
+								}`,
+				"package.json": dedent`
+								{
+									"name": "worker",
+									"version": "0.0.0",
+									"private": true
+								}
+								`,
+			});
+			const worker = helper.runLongLived(`${cmd} --test-scheduled`);
+
+			await worker.waitForReady();
+
+			// The warning should NOT appear when testScheduled is enabled
+			expect(worker.currentOutput).not.toContain(
+				"Scheduled Workers are not automatically triggered"
+			);
+		});
+	});
+
 	describe("Workers + Assets", () => {
 		it(`can modify User Worker during ${cmd}`, async () => {
 			const helper = new WranglerE2ETestHelper();
diff --git a/packages/wrangler/e2e/multiworker-dev.test.ts b/packages/wrangler/e2e/multiworker-dev.test.ts
@@ -606,4 +606,73 @@ describe("multiworker", () => {
 			);
 		});
 	});
+
+	describe("scheduled worker warnings", () => {
+		beforeEach(async () => {
+			await baseSeed(a, {
+				"wrangler.toml": dedent`
+						name = "${workerName}"
+						main = "src/index.ts"
+						compatibility_date = "2024-11-01"
+
+						[triggers]
+						crons = ["* * * * *"]
+
+						[[services]]
+						binding = "BEE"
+						service = '${workerName2}'
+				`,
+				"src/index.ts": dedent/* javascript */ `
+					export default {
+						async fetch(req, env) {
+							return env.BEE.fetch(req);
+						},
+						scheduled(event) {
+							console.log("Worker A scheduled event");
+						}
+					};
+					`,
+			});
+
+			await baseSeed(b, {
+				"wrangler.toml": dedent`
+						name = "${workerName2}"
+						main = "src/index.ts"
+						compatibility_date = "2024-11-01"
+
+						[triggers]
+						crons = ["0 * * * *"]
+				`,
+				"src/index.ts": dedent/* javascript */ `
+					export default {
+						async fetch(req, env) {
+							return new Response("hello world");
+						},
+						scheduled(event) {
+							console.log("Worker B scheduled event");
+						}
+					};
+				`,
+			});
+		});
+
+		it("shows warning with correct port when multiple workers have cron triggers", async () => {
+			const worker = helper.runLongLived(
+				`wrangler dev -c wrangler.toml -c ${b}/wrangler.toml`,
+				{ cwd: a }
+			);
+
+			const { url } = await worker.waitForReady(5_000);
+			const { hostname, port } = new URL(url);
+
+			// The warning should contain the actual port, not "undefined"
+			expect(worker.currentOutput).toContain(
+				"Scheduled Workers are not automatically triggered"
+			);
+			expect(worker.currentOutput).toContain(
+				`curl "http://${hostname}:${port}/cdn-cgi/handler/scheduled"`
+			);
+			expect(worker.currentOutput).not.toContain("undefined");
+		});
+	});
 });
diff --git a/packages/wrangler/src/dev/miniflare/index.ts b/packages/wrangler/src/dev/miniflare/index.ts
@@ -837,23 +837,6 @@ export async function buildMiniflareOptions(
 	remoteProxyConnectionString: RemoteProxyConnectionString | undefined,
 	onDevRegistryUpdate?: (registry: WorkerRegistry) => void
 ): Promise<Options> {
-	if (config.crons?.length && !config.testScheduled) {
-		const host =
-			config.initialIp === "0.0.0.0" || config.initialIp === "::"
-				? "localhost"
-				: config.initialIp.includes(":")
-					? `[${config.initialIp}]`
-					: config.initialIp;
-		const port = config.initialPort;
-
-		logger.once.warn(
-			`Scheduled Workers are not automatically triggered during local development.\n` +
-				`To manually trigger a scheduled event, run:\n` +
-				`  curl "http://${host}:${port}/cdn-cgi/handler/scheduled"\n` +
-				`For more details, see https://developers.cloudflare.com/workers/configuration/cron-triggers/#test-cron-triggers-locally`
-		);
-	}
-
 	const upstream =
 		typeof config.localUpstream === "string"
 			? `${config.upstreamProtocol}://${config.localUpstream}`
diff --git a/packages/wrangler/src/dev/start-dev.ts b/packages/wrangler/src/dev/start-dev.ts
@@ -144,6 +144,15 @@ export async function startDev(args: StartDevOptions) {
 					})
 				);
 			}
+
+			// Print scheduled worker warning with the actual public URL
+			const allDevEnvs = [primaryDevEnv, ...secondary];
+			const hasCrons = allDevEnvs.some(
+				(env) =>
+					env.config.latestConfig?.triggers?.some((t) => t.type === "cron") ??
+					false
+			);
+			maybePrintScheduledWorkerWarning(hasCrons, !!args.testScheduled, url);
 		});
 
 		return {
@@ -347,3 +356,33 @@ function getResolvedSiteAssetPaths(
 		args.siteExclude
 	);
 }
+
+/**
+ * Logs a warning about scheduled workers not being automatically triggered
+ * during local development. This should be called after the server is ready
+ * and the actual URL is known.
+ */
+function maybePrintScheduledWorkerWarning(
+	hasCrons: boolean,
+	testScheduled: boolean,
+	url: URL
+): void {
+	if (!hasCrons || testScheduled) {
+		return;
+	}
+
+	const host =
+		url.hostname === "0.0.0.0" || url.hostname === "::"
+			? "localhost"
+			: url.hostname.includes(":")
+				? `[${url.hostname}]`
+				: url.hostname;
+	const port = url.port;
+
+	logger.once.warn(
+		`Scheduled Workers are not automatically triggered during local development.\n` +
+			`To manually trigger a scheduled event, run:\n` +
+			`  curl "http://${host}:${port}/cdn-cgi/handler/scheduled"\n` +
+			`For more details, see https://developers.cloudflare.com/workers/configuration/cron-triggers/#test-cron-triggers-locally`
+	);
+}
