[wrangler] fix e2e flakiness: use waitForLong to verify response body after deploy (#13057)

petebacondarwin · web-flow · commit 25cb18491f7a · 2026-03-25T20:19:08.000Z
diff --git a/packages/wrangler/e2e/assets-multiworker.test.ts b/packages/wrangler/e2e/assets-multiworker.test.ts
@@ -211,15 +211,21 @@ describe.each(
 					false
 				);
 
-				await expect(fetchText(`${url}/asset`)).resolves.toBe(
-					"<p>have an asset directly</p>"
+				await waitForLong(() =>
+					expect(fetchText(`${url}/asset`)).resolves.toBe(
+						"<p>have an asset directly</p>"
+					)
 				);
-				await expect(fetchText(`${url}/asset-via-binding`)).resolves.toBe(
-					"<p>have an asset via a binding</p>"
+				await waitForLong(() =>
+					expect(fetchText(`${url}/asset-via-binding`)).resolves.toBe(
+						"<p>have an asset via a binding</p>"
+					)
+				);
+				await waitForLong(() =>
+					expect(fetch(`${url}/worker`).then((r) => r.text())).resolves.toBe(
+						"hello world from a worker with assets"
+					)
 				);
-				await expect(
-					fetch(`${url}/worker`).then((r) => r.text())
-				).resolves.toBe("hello world from a worker with assets");
 			});
 
 			it("can fetch a regular worker through a worker with assets, including with rpc", async ({
diff --git a/packages/wrangler/e2e/deployments.test.ts b/packages/wrangler/e2e/deployments.test.ts
@@ -63,11 +63,13 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 
 			const deployedUrl = getDeployedUrl(output);
 
-			const response = await retry(
-				(resp) => !resp.ok,
-				async () => await fetch(deployedUrl)
+			await waitForLong(
+				async () => {
+					const response = await fetch(deployedUrl);
+					expect(await response.text()).toEqual("Hello World!");
+				},
+				{ timeout: 30_000 }
 			);
-			await expect(response.text()).resolves.toEqual("Hello World!");
 		});
 
 		it("lists 1 deployment", async ({ expect }) => {
@@ -98,11 +100,13 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 
 			const deployedUrl = getDeployedUrl(output);
 
-			const response = await retry(
-				(resp) => !resp.ok,
-				async () => await fetch(deployedUrl)
+			await waitForLong(
+				async () => {
+					const response = await fetch(deployedUrl);
+					expect(await response.text()).toEqual("Updated Worker!");
+				},
+				{ timeout: 30_000 }
 			);
-			await expect(response.text()).resolves.toEqual("Updated Worker!");
 		});
 
 		it("lists 2 deployments", async ({ expect }) => {
diff --git a/packages/wrangler/e2e/provision.test.ts b/packages/wrangler/e2e/provision.test.ts
@@ -6,7 +6,7 @@ import { WranglerE2ETestHelper } from "./helpers/e2e-wrangler-test";
 import { fetchText } from "./helpers/fetch-text";
 import { generateResourceName } from "./helpers/generate-resource-name";
 import { normalizeOutput } from "./helpers/normalize";
-import { retry } from "./helpers/retry";
+import { waitForLong } from "./helpers/wait-for";
 
 const TIMEOUT = 500_000;
 const normalize = (str: string) => {
@@ -122,11 +122,13 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 			assert(d1Match?.groups);
 			d1Id = d1Match.groups.d1;
 
-			const response = await retry(
-				(resp) => !resp.ok,
-				async () => await fetch(deployedUrl)
+			await waitForLong(
+				async () => {
+					const response = await fetch(deployedUrl);
+					expect(await response.text()).toEqual("Hello World!");
+				},
+				{ timeout: 30_000 }
 			);
-			await expect(response.text()).resolves.toEqual("Hello World!");
 		});
 
 		it("can inherit bindings on re-deploy and won't re-provision", async ({
@@ -149,11 +151,13 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 				Current Version ID: 00000000-0000-0000-0000-000000000000"
 			`);
 
-			const response = await retry(
-				(resp) => !resp.ok,
-				async () => await fetch(deployedUrl)
+			await waitForLong(
+				async () => {
+					const response = await fetch(deployedUrl);
+					expect(await response.text()).toEqual("Hello World!");
+				},
+				{ timeout: 30_000 }
 			);
-			await expect(response.text()).resolves.toEqual("Hello World!");
 		});
 		it("can inspect current bindings", async ({ expect }) => {
 			const versionsRaw = await helper.run(`wrangler versions list --json`);
