Do not warn user when using a redirected config that came from a config with multiple environments (#11848)

petebacondarwin · web-flow · commit 0eb973deb57b · 2026-01-10T17:53:14.000Z
* do not warn user when using a redirected config that came from a config with multiple environments This reverts these lines https://github.com/cloudflare/workers-sdk/pull/10706/files#diff-c5b22ef21f285ccf53ba4a990d6fba5e40050aee0dbe5a0b6737852164771d06L174-L182 which were added as a refactor but cause the warning to be emitted incorrectly. * add changeset * refactor vitest helpers to be imports * remove check that is not really needed and fails on windows * fix up for Windows
diff --git a/.changeset/social-dogs-sip.md b/.changeset/social-dogs-sip.md
@@ -0,0 +1,7 @@
+---
+"wrangler": patch
+---
+
+Fix incorrect warning about multiple environments when using redirected config
+
+Previously, when using a redirected config (via `configPath` in another config file) that originated from a config with multiple environments, wrangler would incorrectly warn about missing environment specification. This fix ensures the warning is only shown when the actual config being used has multiple environments defined, not when the original config did.
diff --git a/fixtures/redirected-config-worker/src/index.js b/fixtures/redirected-config-worker/src/index.js
@@ -1,5 +1,5 @@
 export default {
 	async fetch(request, env) {
-		return new Response("Generated: " + env.generated ?? false);
+		return new Response("Generated: " + (env.generated ?? false));
 	},
 };
diff --git a/fixtures/redirected-config-worker/tests/index.test.ts b/fixtures/redirected-config-worker/tests/index.test.ts
@@ -1,4 +1,4 @@
-import { execSync } from "child_process";
+import { execSync, spawnSync } from "child_process";
 import { resolve } from "path";
 import { fetch } from "undici";
 import { describe, expect, it, onTestFinished } from "vitest";
@@ -97,7 +97,30 @@ describe("'wrangler dev', when reading redirected config,", () => {
 		const response = await fetch(`http://${ip}:${port}/`);
 		const text = await response.text();
 		expect(response.status).toBe(200);
-		expect(text).toMatchInlineSnapshot(`"Generated: undefined"`);
+		expect(text).toMatchInlineSnapshot(`"Generated: false"`);
+	});
+});
+
+describe("'wrangler deploy', when reading redirected config,", () => {
+	it("uses the generated config", async () => {
+		build("prod");
+		const output = spawnSync("pnpm", ["wrangler", "deploy", "--dry-run"], {
+			cwd: basePath,
+			stdio: "pipe",
+			shell: true,
+			encoding: "utf-8",
+		});
+		expect(output.stdout).toContain(`Using redirected Wrangler configuration.`);
+		expect(output.stdout.replace(/\\/g, "/")).toContain(
+			` - Configuration being used: "build/wrangler.json"`
+		);
+		expect(output.stdout).toContain(
+			` - Original user's configuration: "wrangler.jsonc"`
+		);
+		expect(output.stdout.replace(/\\/g, "/")).toContain(
+			` - Deploy configuration file: ".wrangler/deploy/config.json"`
+		);
+		expect(output.stderr).toMatchInlineSnapshot(`""`);
 	});
 });
 
diff --git a/fixtures/redirected-config-worker/tools/build.ts b/fixtures/redirected-config-worker/tools/build.ts
@@ -7,6 +7,7 @@ const config = {
 	name: "redirected-config-worker",
 	compatibility_date: "2024-12-01",
 	main: "index.js",
+	definedEnvironments: ["prod", "staging"],
 	targetEnvironment: process.env.CLOUDFLARE_ENV,
 	vars: { generated: process.env.CLOUDFLARE_ENV ?? "none" },
 };
diff --git a/packages/wrangler/src/core/register-yargs-command.ts b/packages/wrangler/src/core/register-yargs-command.ts
@@ -5,10 +5,10 @@ import {
 	UserError,
 } from "@cloudflare/workers-utils";
 import chalk from "chalk";
+import { experimental_readRawConfig } from "../../../workers-utils/src";
 import { fetchResult } from "../cfetch";
 import { createCloudflareClient } from "../cfetch/internal";
 import { readConfig } from "../config";
-import { hasDefinedEnvironments } from "../environments";
 import { run } from "../experimental-flags";
 import { logger } from "../logger";
 import { writeOutput } from "../output";
@@ -176,8 +176,15 @@ function createHandler(def: CommandDefinition, commandName: string) {
 						: defaultWranglerConfig;
 
 				if (def.behaviour?.warnIfMultipleEnvsConfiguredButNoneSpecified) {
-					if (!("env" in args)) {
-						if (hasDefinedEnvironments(config)) {
+					if (!("env" in args) && config.configPath) {
+						const { rawConfig } = experimental_readRawConfig(
+							{
+								config: config.configPath,
+							},
+							{ hideWarnings: true }
+						);
+						const availableEnvs = Object.keys(rawConfig.env ?? {});
+						if (availableEnvs.length > 0) {
 							logger.warn(
 								dedent`
 										Multiple environments are defined in the Wrangler configuration file, but no target environment was specified for the ${commandName.replace(/^wrangler\s+/, "")} command.
