Skip to content

Revert "Implement containers snapshot API (#6337)"#6374

Merged
gpanders merged 1 commit intomainfrom
ganders/snapshot-revert
Mar 20, 2026
Merged

Revert "Implement containers snapshot API (#6337)"#6374
gpanders merged 1 commit intomainfrom
ganders/snapshot-revert

Conversation

@gpanders
Copy link
Copy Markdown
Member

This reverts commit d05ea20.

@gpanders gpanders requested review from a team as code owners March 20, 2026 16:07
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 20, 2026

The reverted code matches the pre-original state exactly — dockerApiRequest is a static method on ContainerClient returning ContainerClient::Response, and Response is a nested struct. This is a clean revert back to the pre-#6337 state.

This is a straightforward, clean revert of a feature that was gated behind the workerdExperimental compatibility flag and was never deployed to production. The diff is purely deletions of the snapshot API code, tests, types, and capnp schema additions, with no remaining references to the removed code.

LGTM

github run

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 20, 2026

Merging this PR will degrade performance by 11.09%

❌ 1 regressed benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
Encode_ASCII_32[TextEncoder][0/0/32] 3.2 ms 3.5 ms -11.09%

Comparing ganders/snapshot-revert (4910dab) with main (d106095)2

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (d10a161) during the generation of this report, so d106095 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@gpanders gpanders merged commit 8deb8db into main Mar 20, 2026
27 checks passed
@gpanders gpanders deleted the ganders/snapshot-revert branch March 20, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants