Skip to content

Add more ai agent context, add PR review to architect agent#6130

Merged
jasnell merged 28 commits intomainfrom
jasnell/agent-refinements
Feb 24, 2026
Merged

Add more ai agent context, add PR review to architect agent#6130
jasnell merged 28 commits intomainfrom
jasnell/agent-refinements

Conversation

@jasnell
Copy link
Copy Markdown
Collaborator

@jasnell jasnell commented Feb 21, 2026

You can now ask the Architect agent to perform PR code reviews and ask it to post comments on specific lines of code in a PR. It will use the github cli to post comments on the PR.

Example: #6091 (review)

@jasnell jasnell requested review from a team as code owners February 21, 2026 16:02
@jasnell jasnell requested a review from danlapid February 21, 2026 16:02
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.57%. Comparing base (5b64b20) to head (d4621ed).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6130   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files         409      409           
  Lines      109671   109671           
  Branches    18070    18070           
=======================================
  Hits        77395    77395           
  Misses      21459    21459           
  Partials    10817    10817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell force-pushed the jasnell/agent-refinements branch 5 times, most recently from 4a6a2bc to 6e6fd26 Compare February 21, 2026 22:44
@jasnell jasnell force-pushed the jasnell/agent-refinements branch from c267668 to 3c1621d Compare February 22, 2026 01:09
@jasnell jasnell requested review from a team as code owners February 22, 2026 02:18
@jasnell jasnell force-pushed the jasnell/agent-refinements branch 4 times, most recently from 0111d32 to f4ae472 Compare February 23, 2026 04:10
@jasnell jasnell force-pushed the jasnell/agent-refinements branch from 2b7fd3e to 76ae8f6 Compare February 23, 2026 20:26
@codspeed-hq

This comment was marked as outdated.

You can now ask the Architect agent to perform PR code reviews
and ask it to post comments on specific lines of code in a PR.
It will use the github cli to post comments on the PR.

Rework the agent definition to be more concise and effective.
A distilled set of code review instructions for the
AI agents to use derived from the KJ Style Guide and Tour
with some additional project-specific conventions.

This keeps the agents focused on the most important
details without having to parse and find the entire
style guide on every review.
@jasnell
Copy link
Copy Markdown
Collaborator Author

jasnell commented Feb 24, 2026

/ask-bonk

@elithrar
Copy link
Copy Markdown
Contributor

/bonk give this a quick review. Make suggestions (only).

Consider:

  • system prompt best practices
  • Anthropic prompt engineering guidance
  • ensure that language is LLM-friendly and steers/instructs the model without ambiguity
  • Overall structure and ordering weights the most critical advice the most heavily

@ask-bonk

This comment was marked as resolved.

@elithrar
Copy link
Copy Markdown
Contributor

/bonk these are good. Make line/multi-line suggestions with your changes for us to accept.

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: Concrete suggestions from prior review

Here are the line-level suggestions from the previous structural review. Each comment is a self-contained suggestion that can be accepted independently.

Prioritized by impact: HIGH items reorder critical constraints for better LLM attention weighting; MEDIUM items improve clarity; LOW items are polish.


These review comments were generated by an AI assistant (bonk) and may not be perfect. Please evaluate each suggestion on its merits.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment was marked as duplicate.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@ask-bonk

This comment has been minimized.

@jasnell jasnell enabled auto-merge February 24, 2026 04:11
@jasnell jasnell disabled auto-merge February 24, 2026 04:35
@jasnell jasnell merged commit c08a675 into main Feb 24, 2026
62 of 67 checks passed
@jasnell jasnell deleted the jasnell/agent-refinements branch February 24, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants