Allow empty protocols array in WebSocket constructor#5963
Merged
Conversation
Merging this PR will degrade performance by 12.13%
Performance Changes
Comparing 
Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5963 +/- ##
==========================================
- Coverage 70.14% 70.14% -0.01%
==========================================
Files 407 407
Lines 107188 107190 +2
Branches 17965 17966 +1
==========================================
- Hits 75192 75191 -1
- Misses 21209 21214 +5
+ Partials 10787 10785 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vicb
reviewed
Jan 27, 2026
vicb
reviewed
Jan 27, 2026
Co-authored-by: Victor Berchet <victor@suumit.com>
npaun
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5822
Per the WebSocket spec, an empty protocols array is valid and equivalent to not specifying any protocols. The spec uses [] as the default value for the optional protocols parameter.
Previously, workerd threw a SyntaxError when an empty array was passed. Now we simply skip setting the Sec-WebSocket-Protocol header in this case.