Skip to content

Fix TextDecoderStream fatal default and assert.throws with Error constructor#5674

Merged
anonrig merged 1 commit intomainfrom
yagiz/fix-decode-attributes
Dec 11, 2025
Merged

Fix TextDecoderStream fatal default and assert.throws with Error constructor#5674
anonrig merged 1 commit intomainfrom
yagiz/fix-decode-attributes

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Dec 10, 2025

Fixes #5383


Changes are necessary to be more "web" compliant...

  • Changes fatal default to false (to be WPT compliant) - might require a compat flag or not...
  • node:assert throws with Error constructor now properly handles errors.

@anonrig anonrig requested review from jasnell and npaun December 10, 2025 22:06
@anonrig anonrig requested review from a team as code owners December 10, 2025 22:06
@anonrig anonrig force-pushed the yagiz/fix-decode-attributes branch from 8aeca67 to ae55f55 Compare December 10, 2025 22:39
@anonrig anonrig requested a review from jasnell December 10, 2025 22:40
@anonrig anonrig force-pushed the yagiz/fix-decode-attributes branch from ae55f55 to 3c9f186 Compare December 10, 2025 22:43
@anonrig anonrig force-pushed the yagiz/fix-decode-attributes branch from 3c9f186 to abb9a78 Compare December 10, 2025 22:47
@anonrig anonrig requested a review from jasnell December 10, 2025 22:47
@anonrig anonrig enabled auto-merge (squash) December 10, 2025 22:48
@anonrig anonrig merged commit de9b6d2 into main Dec 11, 2025
34 of 43 checks passed
@anonrig anonrig deleted the yagiz/fix-decode-attributes branch December 11, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix argument validation for TextDecoder fatal option

2 participants