Fix Body::text() and Body::json() to handle BOMs#5621
Merged
Conversation
npaun
approved these changes
Dec 1, 2025
Member
|
This one is technically observable, isn't it? Like what if I had crappy code that expected the BOM there |
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
reviewed
Dec 1, 2025
kentonv
reviewed
Dec 1, 2025
560fc65 to
d475224
Compare
jasnell
reviewed
Dec 1, 2025
jasnell
reviewed
Dec 1, 2025
d475224 to
dc9792f
Compare
jasnell
reviewed
Dec 1, 2025
jasnell
reviewed
Dec 1, 2025
npaun
approved these changes
Dec 3, 2025
jasnell
reviewed
Dec 5, 2025
jasnell
reviewed
Dec 5, 2025
Collaborator
|
Re-opening this. The change is necessary to improve correctness and spec compliance. changes:
|
14748e5 to
3e89a25
Compare
Collaborator
3e89a25 to
55ce052
Compare
npaun
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4712
Fixes #4977