Skip to content

add process.assert#5156

Merged
anonrig merged 1 commit intomainfrom
yagiz/add-process-assert
Sep 23, 2025
Merged

add process.assert#5156
anonrig merged 1 commit intomainfrom
yagiz/add-process-assert

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Sep 23, 2025

Fixes #5155

@anonrig anonrig requested review from a team as code owners September 23, 2025 16:44
@anonrig anonrig requested a review from a team September 23, 2025 16:44
@anonrig anonrig requested a review from a team as a code owner September 23, 2025 16:44
@anonrig anonrig force-pushed the yagiz/add-process-assert branch 2 times, most recently from 9543bd7 to 040bc0f Compare September 23, 2025 16:58
Copy link
Copy Markdown
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to do this would be to create a public_process_lts.ts which reexports everything along with assert, and add the LTS to the branching. That would avoid exposing assert at all for object keys when it is deprecated.

@anonrig anonrig force-pushed the yagiz/add-process-assert branch from 040bc0f to f5a34ed Compare September 23, 2025 19:31
@anonrig anonrig enabled auto-merge (rebase) September 23, 2025 19:31
@anonrig anonrig force-pushed the yagiz/add-process-assert branch from f5a34ed to 21909e4 Compare September 23, 2025 19:31
@anonrig anonrig merged commit 0d6890c into main Sep 23, 2025
32 of 33 checks passed
@anonrig anonrig deleted the yagiz/add-process-assert branch September 23, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assert is missing APIs in node:process v2

4 participants