Implement connect_pass_through experimental compat flag.#4171
Merged
Conversation
a00f9b3 to
50bcd7c
Compare
Member
Author
|
(Added test, seems to work.) |
See comments in compatibility-date.capnp for explanation. Miniflare needs this.
50bcd7c to
9b1919d
Compare
jasnell
reviewed
May 20, 2025
jasnell
reviewed
May 20, 2025
jasnell
reviewed
May 20, 2025
jasnell
approved these changes
May 20, 2025
Collaborator
jasnell
left a comment
There was a problem hiding this comment.
Couple minor nits but consider them optional
Co-authored-by: James M Snell <jsnell@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments in compatibility-date.capnp for explanation. Miniflare needs this.
cc @penalosa