Closed
Conversation
jasnell
reviewed
Oct 25, 2024
jasnell
reviewed
Oct 25, 2024
651bc4e to
ac911a3
Compare
mikea
reviewed
Oct 28, 2024
4e5b2c9 to
9417577
Compare
mikea
approved these changes
Oct 28, 2024
515dc86 to
902521e
Compare
523aecd to
b0b30c0
Compare
b0b30c0 to
9a27009
Compare
kentonv
reviewed
Oct 29, 2024
kentonv
reviewed
Oct 29, 2024
This was referenced Nov 1, 2024
Member
Author
|
Since multiple PRs have landed, we can close this pull-request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this pull-request is to create an intermediary step between TypeScript compiler and Workerd compilation step to create compile caches. Compile caches will be used by the main binary to improve the startup time of the built-in modules (and only the built-ins).
Technical details:
The newly introduced binary accepts a string to the path of a file list that contains every path to be compile cached. With the current change the build process will slightly change to the following:
Limitations: