Skip to content

Update to V8 12.8#2441

Merged
fhanau merged 5 commits intomainfrom
felix/v8-128
Aug 14, 2024
Merged

Update to V8 12.8#2441
fhanau merged 5 commits intomainfrom
felix/v8-128

Conversation

@fhanau
Copy link
Copy Markdown
Contributor

@fhanau fhanau commented Jul 25, 2024 •
edited
Loading

  • Drop patch setting V8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA, the V8 bazel build now enables it by default
  • Update promise context tagging patch following V8 type casting changes
  • Update absl and ICU dependencies to version used by V8
  • Manually add define for Windows 10 which is now required by V8, this is not
    reflected in V8's bazel files so far.
  • Upgrade LLVM 15 => 16 to support V8 12.8
  • Resolve EmbedderRootsHandler deprecation warning
  • Backport wasm race condition fixes – this resolves test failures under ASan.

@fhanau fhanau force-pushed the felix/v8-128 branch 6 times, most recently from 2f35cae to e4a4890 Compare August 1, 2024 14:57
@fhanau fhanau mentioned this pull request Aug 9, 2024
Merged
@jasnell
Copy link
Copy Markdown
Collaborator

jasnell commented Aug 12, 2024

The failure with promise-wrapper-test appears to be caused by the use of SetNativeDataProperty(...) when configuring the read-only property. Switching to using SetAccessorProperty(...) allows the test to pass but has other side effects. We had to make a similar change with regards to non-read only properties recently so it appears the v8 continued to make some changes here that change the behavior of SetNativeDataProperty(...) further.

fhanau added 4 commits August 13, 2024 00:03
@fhanau
Update to V8 12.8
386743f 
- Drop patch setting V8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA, the V8
  bazel build now enables it by default
- Update promise context tagging patch following V8 type casting changes
- Update absl and ICU dependencies to version used by V8
- Manually add define for Windows 10 which is now required by V8, this is not
  reflected in V8's bazel files so far.
@fhanau
Upgrade LLVM 15 => 16 to support V8 12.8
636986f
@fhanau
Resolve EmbedderRootsHandler deprecation warning
1e1fb58 
We were already using the new behavior here, but V8 now wants us to use the
default constructor instead of passing the new option.
@fhanau
Backport wasm race condition fixes
ce5c54f
@fhanau fhanau requested a review from jasnell August 13, 2024 13:07
@fhanau fhanau marked this pull request as ready for review August 13, 2024 13:07
@fhanau fhanau requested review from a team as code owners August 13, 2024 13:07
@fhanau fhanau requested a review from harrishancock August 13, 2024 13:07
@fhanau
[JSG] Explicitly set template parameter in returnRejectedPromise()
6e88bad 
The compiler would drop the reference otherwise, resulting in the info parameter
being copyied implicitly. This caused //src/workerd/io:promise-wrapper-test to
fail.
@fhanau fhanau merged commit 3f57135 into main Aug 14, 2024
@fhanau fhanau deleted the felix/v8-128 branch August 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@harrishancock harrishancock Awaiting requested review from harrishancock harrishancock is a code owner automatically assigned from cloudflare/workers-runtime-1

+1 more reviewer

@anonrig anonrig anonrig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhanau @jasnell @anonrig