Skip to content

Refactor DOMException#2139

Merged
jasnell merged 1 commit intomainfrom
jsnell/domexception-refactor
May 23, 2024
Merged

Refactor DOMException#2139
jasnell merged 1 commit intomainfrom
jsnell/domexception-refactor

Conversation

@jasnell
Copy link
Collaborator

@jasnell jasnell commented May 18, 2024

  • Eliminate the extra object allocated for the stack using the new v8::Exception::CaptureStackTrace API.
  • Avoid having to use the JS constructor to create instances by using the FunctionTemplate directly

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

@jasnell jasnell force-pushed the jsnell/domexception-refactor branch from 1446b3b to 030d268 Compare May 23, 2024 21:25
* Eliminate the extra object allocated for the stack using the
  new v8::Exception::CaptureStackTrace API.
* Avoid having to use the JS constructor to create instances by
  using the FunctionTemplate directly
@jasnell jasnell force-pushed the jsnell/domexception-refactor branch from 030d268 to 5950a1b Compare May 23, 2024 21:49
@jasnell jasnell merged commit 87097c1 into main May 23, 2024
@jasnell jasnell deleted the jsnell/domexception-refactor branch May 23, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants